On Mon, 9 Mar 2015 10:57:02 +0100, Adam Borowski <kilobyte@angband.pl> wrote: > On Sun, Mar 08, 2015 at 04:20:08PM +0100, Stephen Kitt wrote: > > Could you fix up debian/patches/debian-changes? It's just got > > auto-generated template headers... Or is that because you're using > > single-debian-patch in debian/source/options? > > The latter. I guess, dpkg-source shouldn't insert that template if > single-debian-patch is set. It's pointless to duplicate the work if all > changes are already tracked and documented in a proper VCS. OK, that's fine by me. (I guess you could file a bug if one isn't already filed!) > > Also, I know this has been debated before, but it seems rather > > restrictive to call the binary package git-restore-mtime, given that > > there are other useful git tools in the package. > > Actually, it was the source name that was discussed. > > As for binary, my reason is that "git restore-mtime" is the main point of > interest here, the other tools being just thrown in. Their usefulness is > quite marginal. In fact, I dropped two altogether: git-branches-rename and > git-rebase-theirs as both can be reproduced by an one-liner. > > As for three tools that I left in, git-find-uncommited-repos probably should > be axed too -- it's just "find -name .git -execdir 'git status'" with some > output massaging. git-strip-merge is both situational and trivial to > reproduce. The only other tool with some real use is git-clone-subset. > > Thus, it would feel odd to have a package named "git-tools" that contains > only two tools of some note. OK, stick with git-restore-mtime as the binary package then. I'm wondering if it would be better to call the source package git-mestrelion-tools... > > While I'm at it, given that you're shipping extra manpages, wouldn't it be > > worth it to ship the help2man-generated manpage as well, instead of > > rebuilding it every time? > > I build it from source to make sure new upstream changes are incorporated. That's what I reckoned, although you'd still need to tweak the version number in debian/rules every time. > On the other hand, this makes it near impossible to adjust the output, and > is inconsistent with the other three manpages, all of which are > hand-crafted. Thus, you're probably right, it would be better to ship > the manpage instead of building it from source. Shall I wait for that then before uploading? Regards, Stephen
Attachment:
pgp_k3S1m5eMq.pgp
Description: OpenPGP digital signature