[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#778729: Try 2: Bug#778729: RFS: git-tools/1.0.0-1 [ITP]



Hi Adam,

On Tue, 3 Mar 2015 23:52:15 +0100, Adam Borowski <kilobyte@angband.pl> wrote:
> On Thu, Feb 19, 2015 at 02:53:52AM +0100, Adam Borowski wrote:
> > * Package name    : git-tools
> > * URL             : https://github.com/MestreLion/git-tools
> > 
> > It builds those binary packages:
> >   git-restore-mtime - set timestamps to the date of a file's last commit
> 
> Hi guys again!  Lemme ping you, as sadly no one offered to sponsor this
> package yet...  I made a few changes:
> * fixed a reference to GPL2 (should be GPL3)
> * moved my hand-crafted manpages to debian/ (so they don't require a patch)
> * actually installed them (only the help2manned one was there[¹])
> * renamed the source to git-tools, per Chris Lamb's suggestion.
> * picked a fix from upstream

Thanks for packaging this!

Could you fix up debian/patches/debian-changes? It's just got auto-generated
template headers... Or is that because you're using single-debian-patch in
debian/source/options?

Also, I know this has been debated before, but it seems rather restrictive to
call the binary package git-restore-mtime, given that there are other useful
git tools in the package.

While I'm at it, given that you're shipping extra manpages, wouldn't it be
worth it to ship the help2man-generated manpage as well, instead of
rebuilding it every time?

Regards,

Stephen

Attachment: pgpSndHTumDeL.pgp
Description: OpenPGP digital signature


Reply to: