On Sun, 2014-10-26 at 18:53 -0400, Harlan Lieberman-Berg wrote: > 1. There are several generated files included as part of the tarball > that really should be removed, if possible. The m4 stuff has several > examples of generated files in it - aclocal.m4, several Makefile.in's, > much of the content in ./build-aux (depcomp, config.sub, ar-lib, > test-driver, among others). If you could go through and remove these > generated files, it's preferable. As much as possible, the upstream > source should be kept clean and files regenerated as needed. (See > https://wiki.debian.org/UpstreamGuide#Generated_files for more > information). The upstream tarball (but *not* the upstream git repo) is expected to contain autotools cruft for packages using autotools so this is fine. However, the Debian package should use dh-autoreconf to rebuild and or update them from their canonical sources in autoconf/automake/etc. > 2. In a similar vein, the documentation u2f-host.pdf should be > regenerated at build time, rather than the pdf be included. If it can > be removed from the upstream tarball, that would be preferable, but if > not, it should be regenerated at build-time in the debian/rules. Indeed. You can add a second download for the prebuilt docs. -- bye, pabs https://wiki.debian.org/PaulWise
Attachment:
signature.asc
Description: This is a digitally signed message part