[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#712787: ITP for Distkeys



Am Montag, 22. September 2014, 09:52:55 schrieb Eriberto Mota:
> Hi Martin,

Hello Eriberto,

thanks for your continuing review.

> 2014-09-22 7:19 GMT-03:00 Martin Steigerwald <ms@teamix.de>:
> > Am Mittwoch, 17. September 2014, 17:47:29 schrieb Eriberto:
> >> Hi Martin,
> > 
> > Hello Eriberto,
> > 
> >> About your package, please:
> >> 
> >> 1. Use DH 9 instead DH 8.
> 
> You didn't make your package full compatible with DH9 yet. So, edit
> the d/compat file and change from 8 to 9. In d/control, change from
> 9.0.0 to 9.
> 
> >> 3. d/copyright:
> >>     - In header, the field 'Source' is wrong.
> >>     - The 'AUTHORS' file says: 'Licensed unter GPL-2. See COPYING.'.
> >> 
> >> So, the upstream code is GPL-2, not 2+. Note the word 'unter'. :-)
> >> 
> >>     - Your year as packager should be 2013.
> > 
> > What do you mean by that? I already have
> > 
> > Files: debian/*
> > Copyright: 2013-2014 Martin Steigerwald <ms@teamix.de>
> > License: GPL-3+
> > 
> > Anything else needed?
> 
> Sorry for my mistake. As the package in new in Debian, the packaging
> year must be 2014.

I think 2013-2014 would be good to go. I thus kept it as such. If you feel 
strongly about using just 2014 I might do it, but I would like to hear a good 
reason for that. All I know about copyright that it spans years in which work 
was done about something.

> >> 4. d/rules: please, remove all comments (from '# -*- makefile' up to
> >> 'verbose mode').
> 
> Please, do it.
> 
> >> 5. You will need update the Homepage address. Can your current
> >> homepage allow scans from d/watch file?
> > 
> > Did those and re-uploaded.
> 
> Please, in d/watch, change from 'tags' to 'releases'. It will allow
> that uscan command can make download of the new releases.

I did all of the other. Re-uploaded.

Ciao,
Martin



-- 
Martin Steigerwald  | Consultant / Trainer

teamix GmbH
Südwestpark 43
90449 Nürnberg

Tel.:  +49 911 30999 55 | Fax: +49 911 30999 99
mail: martin.steigerwald@teamix.de | web:  http://www.teamix.de | blog: http://blog.teamix.de

Amtsgericht Nürnberg, HRB 18320 | Geschäftsführer: Oliver Kügow, Richard Müller


**Nicht verpassen: Die teamix Wissenstage im Herbst - JETZT ANMELDEN**

21.10. Nürnberg | 22.10. Mainz | 23.10. München | 04.11. Bayreuth
Anmeldung unter: http://www.teamix.de/teamix/veranstaltungen/wissenstage-herbst-2014/herbst-2014.html


Reply to: