[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#762678: RFS: hexer/0.1.8-1 (new upstream, refresh packaging, ack NMU)



* Peter Pentchev <roam@ringlet.net>, 2014-09-24, 14:50:
I've uploaded a new version to the same mentors.d.n location.

... which is:
https://mentors.debian.net/debian/pool/main/h/hexer/hexer_0.1.8-1.dsc

You removed debian/dirs and debian/docs, but that doesn't seem to be documented in the changelog.

The default pager should be "pager", not "more" (see Policy §11.4).

The following problems don't necessarily have to be fixed in this upload; please use your own discretion:

Here[0], hexer doesn't restore background color on exit. I don't like my shell prompt in blue! :-(

Lintian says:
X: hexer: binary-file-built-without-LFS-support usr/bin/hexer

And indeed, I can't open files bigger than 2G. But on a second thought, hexer seems to load whole file into memory, so maybe it's good it didn't attempt to load anything that big. ;->

codespell(1) finds a bunch of typos:
./exh.c:303: occurence  ==> occurrence
./hexer.h:175: diffrent  ==> different
./hexer.h:180: diffrent  ==> different
./hexer.h:203: diffrent  ==> different
./tio.c:1048: occurence  ==> occurrence
./regex.c:215: exept  ==> except
./tio.h:161: occured  ==> occurred
./tio.h:507: availabe  ==> available
./tio.h:509: availabe  ==> available
./tio.h:513: availabe  ==> available
./termlib.c:385: paramters  ==> parameters
./commands.c:99: occurence  ==> occurrence
./main.c:94: availabe  ==> available
./buffer.h:60: Funtion  ==> Function
./buffer.h:75: assertation  ==> assertion
./edit.c:1178: availabe  ==> available
./edit.c:1330: availabe  ==> available

spellintian[1] finds a few more:
exh.c: adresses -> addresses
tio.c: makeing -> making
port.c: interupted -> interrupted
termlib.c: paramters -> parameters
main.c: comand -> command

[0] TERM=linux
[1] https://bitbucket.org/jwilk/spellintian

--
Jakub Wilk


Reply to: