Bug#760720: qrouter review

[Ruben Undheim <ruben.undheim@gmail.com>]

Hi,

I don't have any problems with qrouter and tkcon2.7, but magic does
not seem to like 2.7. And the second issue you mention is not really
relevant for the debian package. So it shold be fine as it is now -
letting it use the tkcon version available in debian.

Then, Harlan, I think the package is ready to be reviewed again! :)


Regards,
Ruben

2014-09-21 3:51 GMT+02:00 Tim Edwards <tim@opencircuitdesign.com>:
>
> Hello Ruben,
>
>> After a closer look, it seems like the version bundled with qrouter
>> and magic is just an older version of tkcon.tcl (2.3). I don't see why
>> it would not work completely fine also with the newest version of
>> tkcon. I've tried qrouter with tkcon 2.7 and I don't see any problems
>> (maybe Tim knows more?)
>
> Interesting.  After years of nobody mentioning it, I get two requests to
> update tkcon.tcl within a few days.
>
> Just note several things:
>
> 1)  tkcon.tcl was broken by Tcl version 2.6 and would not scroll through
>      the history.  This is probably fixed, but it's best to check.  There's a
>      patch for it floating around, if needed.
>
> 2)  I used a slightly modified tkcon.tcl, in which at the top I changed "wish"
>      to "$(QROUTER_WISH:=wish)" (or something like that).  This is to make
>      sure that qrouter runs the version of wish that it was compiled for.  This
>      could also be done in the launching shell script, to make sure "wish" is
>      aliased to the correct executable.  That would be preferred, as it prevents
>      having a modified version of tkcon.tcl.
>
>               ---Tim