Bug#760720: qrouter review
Hi,
After a closer look, it seems like the version bundled with qrouter
and magic is just an older version of tkcon.tcl (2.3). I don't see why
it would not work completely fine also with the newest version of
tkcon. I've tried qrouter with tkcon 2.7 and I don't see any problems
(maybe Tim knows more?)
But then, there are several ways of doing this:
1. Make tkcon an install dependency of qrouter and change the script
which calls tkcon (a simple patch)
2. Make tkcon an install dependency of qrouter and make a symlink from
/usr/lib/qrouter/tkcon.tcl to /usr/bin/tkcon.
3. Make tkcon a build dependency of qrouter and copy tkcon.tcl from
the installed tkcon package during the build
Which method is preferable? I would think #1 is the cleanest and best.
Regards,
Ruben
2014-09-20 5:35 GMT+02:00 Paul Wise <pabs@debian.org>:
> On Sat, Sep 20, 2014 at 3:54 AM, Ruben Undheim wrote:
>
>> It seems like these are two different tkcon.tcl versions. I've seen
>> that the package "magic" also bundles a tkcon.tcl version. You are
>> possibly right here, but I would like to keep it as it is, as for now
>> at least.
>
> Are these independent implementations or forks? Either way it would be
> good if they could be merged so that there is only one version. Could
> you work on that?
>
> If they are forks and you don't remove the version in qrouter, please
> notify the security team about the embedded code copy:
>
> https://wiki.debian.org/EmbeddedCodeCopies
>
> --
> bye,
> pabs
>
> https://wiki.debian.org/PaulWise
Reply to: