Re: Bug#762228: RFS: ufoai-music review
Hi Markus,
On 2014-09-20 01:22, Markus Koschany wrote:
> The debian/copyright file is identical for ufoai-data, ufoai-music and
> ufoai-maps.
I find this somewhat confusing.
Generally speaking, I don't believe that listing the copyright of files
which are not part of the source package (in fact, which are part of
another package) is policy-conform, regardless of whether upstream
created the source split, or you.
But specifically, imagine I fork the ufoai package to create my own
modded version, and imagine I think the music is fine so I just depend
on that package instead of forking that one, too. The music package
would then, in its copyright, list incorrect information, as through my
fork, the copyright of some of the other files would have changed.
> I did this on purpose because upstream does not distinguish
> between those files. In fact they maintain everything in one Git
> repository and the LICENSE file contains all copyright information for
> the game data. Thus I decided to use a script to parse all license
> information and then I generated a machine-readable debian/copyright
> file out of them.
> This makes it far easier to review the packages IMO because you only
> have to check and run the script on LICENSES.
Why not simply modify this script to generate 4 copyright files instead
of 1 (one for each source package)? For example, if the music is in a
subdirectory, you can split by that.
> It also comes with the advantage that all files are machine-readable
> now. Thus wildcards, except for the Files: * paragraph, aren't
> necessary and the whole copyright information are more precise.
If you have a directory base/textures/tex_trak/, and all the files in
there were created by the same author, then listing them individually
or using the "*" glob pattern convey exactly the same amount of
information, but using "*" makes the file far more (human-)readable.
Regards,
Christian
Reply to: