|
Hi Eriberto, Sorry this is taking so long. I had a lot of homework this week. I have 2 questions: 1. If somebody is mentioned in the upstream changelog as having made a contribution but does not appear on any copyright notices, do they belong anywhere in the debian/copyright folder? 2.Once I have a VCS set up, should I still make uploads to mentors.debian.net? 3. I noticed there is docbook documentation associated with the upstream project. I forget which utilities I ran to try to convert it, but they all crashed. What should I do with it? I didn't even know kcm addons were supposed to have man pages. 3b. What utilities do you recommend in relation to question 3? I have never used docbook before. Thanks, --Shawn
I hope to have the fixes you mentioned done by Sunday.
On Monday, September 15, 2014 19:41:43 Eriberto wrote: > Hi Shawn, > > About your package, please: > > 1. Please, create a VCS to control your debian/ versions. You can use > github or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to > d/control. You can see an example here[1]. > > [1] > http://sources.debian.net/src/yowsup/0.0~git20140314.938cf1-1/debian/contro > l/ > > 2. d/control: > - In Homepage field you must to use > 'http://kde-apps.org/content/show.php?content=137789' only. Please, > use this address in d/copyright too. > - Can you put semicolons at end of each line of the list and > separate the paragraphs? See an example here[1]. > - Fix the word "connectivity". > > [1] http://sources.debian.net/src/xombrero/2:1.6.3-1/debian/control/ > > 3. d/copyright: in source code I can see names as Darwin M. Bautista > and Christian Hubinger. Please, inspect carefully the upstream code > and add all authors name. > > 4. d/rules: what does this line? --> include /usr/share/dpkg/default.mk > > 5. d/watch: your watch file don't work. Please, see here[2] how to > make a watch file. Remove all trash. > > [2] http://eriberto.pro.br/blog/?p=1459 > > 6. There are Lintian messages in your package: > > I: kcm-ufw source: debian-watch-contains-dh_make-template > I: kcm-ufw: spelling-error-in-binary usr/lib/kde4/kcm_ufw.so incomming > incoming X: kcm-ufw: package-contains-broken-symlink > usr/share/doc/kde/HTML/en/kcontrol/ufw/common ../../common > X: kcm-ufw: package-contains-broken-symlink > usr/share/doc/kde/HTML/es/kcontrol/ufw/common ../../common > > 7. Put this line in d/rules: > > export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed > > To solve these issues: > > dpkg-shlibdeps: warning: package could avoid a useless dependency if > debian/kcm-ufw/usr/lib/kde4/kcm_ufw.so > debian/kcm-ufw/usr/lib/kde4/libexec/kcm_ufw_helper were not linked > against libQtDBus.so.4 (they use none of the library's symbols) > dpkg-shlibdeps: warning: package could avoid a useless dependency if > debian/kcm-ufw/usr/lib/kde4/kcm_ufw.so > debian/kcm-ufw/usr/lib/kde4/libexec/kcm_ufw_helper were not linked > against libgcc_s.so.1 (they use none of the library's symbols) > dpkg-shlibdeps: warning: package could avoid a useless dependency if > debian/kcm-ufw/usr/lib/kde4/kcm_ufw.so was not linked against > libQtSvg.so.4 (it uses none of the library's symbols) > > 8. Run the command 'blhc --all kcm-ufw_0.4.3-1_amd64.build' and you > will see several messages. To solve it, add to debian/rules: > > export DEB_BUILD_MAINT_OPTIONS = hardening=+all > > Thanks for your work. > > Cheers, > > Eriberto > > 2014-09-14 18:06 GMT-03:00 Shawn Sörbom <shawn@sorbom.com>: > > Got it. I will do that today. > > Thanks, > > --Shawn |