Bug#750034: apt-zeroconf review
On Fri, Sep 19, 2014 at 2:53 AM, Harlan Lieberman-Berg wrote:
> apt-zeroconf is in pretty good shape.
Some things that should be fixed before upload (I don't have time to
be a sponsor):
I'm not sure but I believe the removal of users in postrm is against
policy, especially when /var/lib/apt-zeroconf/ is not removed at the
same time.
The convention Debian appears to be moving to for system users is
_name (some use Debian-name), I think it would be a good idea to use
that.
I noticed the package does not install if avahi isn't running,
shouldn't it depend on avahi too?
> 2. Speaking of the patches, some of them still have sample DEP-3
> headers in there that should be removed.
Also, all of them appear to have the same Bug-Debian headers, which is
confusing.
Other things that would be nice to fix:
The override_dh_auto_install target in debian/rules doesn't seem to be
needed, dh_auto_install should take care of this case.
Automated checks:
$ lintian
I: apt-zeroconf source: wildcard-matches-nothing-in-dep5-copyright
debian/copying (paragraph at line 74)
I: apt-zeroconf source: wildcard-matches-nothing-in-dep5-copyright
debian/patches/notes (paragraph at line 90)
I: apt-zeroconf source: wildcard-matches-nothing-in-dep5-copyright
notes.txt (paragraph at line 134)
I: apt-zeroconf source: unused-file-paragraph-in-dep5-copyright
paragraph at line 134
I: apt-zeroconf source: unused-file-paragraph-in-dep5-copyright
paragraph at line 74
I: apt-zeroconf source: unused-file-paragraph-in-dep5-copyright
paragraph at line 90
P: apt-zeroconf: no-upstream-changelog
I: apt-zeroconf: capitalization-error-in-description debian Debian
$ cme check dpkg
Warning in 'patches:"apt_pkg.version_compare" Synopsis' value 'Replace
calls to apt_pkg.VersionCompare with calls to
apt_pkg.version_compare': Synopsis is too long.
Warning in 'control source Build-Depends:0' value 'python-all (>=
2.6.6-3)': unnecessary versioned dependency: python-all >= 2.6.6-3.
Debian has squeeze -> 2.6.6-3+squeeze7; wheezy -> 2.7.3-4+deb7u1;
jessie -> 2.7.8-1; sid -> 2.7.8-1; jessie -> 2.7.8-1+b1; sid ->
2.7.8-1+b1;
$ codespell --quiet-level=3
./aptzeroconf/avaphi.py:24: availablity ==> availability
./aptzeroconf/http.py:220: anyother ==> any other
./aptzeroconf/http.py:347: availablity ==> availability
./aptzeroconf/util.py:59: adress ==> address
./aptzeroconf/stats.py:38: inital ==> initial
./debian/patches/apt_pkg.version_compare:27: availablity ==> availability
$ duck
<several of the upstream email addresses don't appear to be valid>
$ pep8 --ignore W191 .
<lots>
$ pyflakes .
./aptzeroconf/daemon.py:117: undefined name 'err'
./aptzeroconf/http.py:148: local variable 'pagePath' is assigned to
but never used
--
bye,
pabs
https://wiki.debian.org/PaulWise
Reply to: