[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#750034: apt-zeroconf review



Control: tag -1 +moreinfo

Hello David!

apt-zeroconf is in pretty good shape.  I've got a couple little things
for you to fix here and there - nothing too major.

1.  Have the patches that you put in been sent upstream?  There's no bug
URLs or confirmations in the headers of the patches.

2.  Speaking of the patches, some of them still have sample DEP-3
headers in there that should be removed.

3. Instead of having separate licensing blocks for each file, you can
make your life a lot easier by grouping similarly licensed and
copyrighted files together.

For example, instead of:

Files: a/foo
Copyright: 1900, Some Guy
License: Expat

Files: a/bar
Copyright: 1900, Some Guy
License: Expat

You can combine them into a single "Files: a/*" directive, if that's all
that's in the directory "a".

If all the files in the upstream source are licensed the same way, as
the project is, you can just use Files: *, and then have a separate
Files block for the debian/* content.

4. There are some file definitions in d/copyright that no longer exist.
Please check and remove them, when applicable.

Thanks for your contribution to Debian!  When you've made those changes,
please update the bug so I or someone else can take a look.

-- 
Harlan Lieberman-Berg
~hlieberman


Reply to: