Hi Jörg,
On Sun, 14 Sep 2014 14:29:18 +0200, Jörg Frings-Fürst
<debian@jff-webhosting.net> wrote:
> Am Sonntag, den 14.09.2014, 12:35 +0200 schrieb Stephen Kitt:
> Line in d/changelog and comments in d/rules removed.
> I think that hardening=+all is not necessary for argyll.
OK.
> [...]
> > > * debian/patches/
> > > - New 110_dispwin_segfault.patch to prevent segfault by
> > > wrong parameter (Closes: #700253)
> >
> > I see other patches as well... 15_jam.patch.org should be removed, along
> > with the various patches which are no longer used in the series file (and
> > you should clean up the series file too). In 110_dispwin_segfault.patch,
> > is there a link to the mailing list archives you could copy in the
> > "Forwarded" item?
>
> Link is included. Useless patches deleted and from d/p/series removed.
I see a link in 15_jam.patch, but not in 110_dispwin_segfault.patch.
Lintian doesn't reveal anything nasty about the package; there are a few
pre-built Windows binaries, but the source is also included so there's no
need to repack the source. The warning about the short license names is a
false-positive which is fixed in lintian 2.5.27.
Upgrading argyll does reveal a real problem though... Given that you're
shipping all the documentation in argyll-doc, and symlinking from the other
two packages, you need to replace the old directories with symlinks, using
something like this in argyll's postinst:
# Replace documentation directory with symlink
if [ -d /usr/share/doc/argyll ] && [ ! -L /usr/share/doc/argyll ]; then
if rmdir /usr/share/doc/argyll 2>/dev/null; then
ln -sf argyll-doc /usr/share/doc/argyll
fi
fi
Otherwise /usr/share/doc/argyll ends up being an empty directory.
Incidentally, doing this means that argyll depends on argyll-doc; was that
intentional?
Regards,
Stephen
Attachment:
signature.asc
Description: PGP signature