Hallo Stephen,
Thank you for reviewing argyll.
Am Sonntag, den 14.09.2014, 12:35 +0200 schrieb Stephen Kitt:
> Hi,
>
> Thanks for taking care of ArgyllCMS! Here's a quick review.
>
> On Sun, 14 Sep 2014 11:11:43 +0200, Jörg Frings-Fürst
> <debian@jff-webhosting.net> wrote:
> > * New Maintainer (Closes: #720178).
> > * New upstream release (Closes: #742658).
> > * debian/rules:
> > - Add get-orig-source.
> > - Remove useless --with quilt from dh $@
> > - Enable hardening=+all
>
> But the line is commented out in debian/rules!
>
Line in d/changelog and comments in d/rules removed.
I think that hardening=+all is not necessary for argyll.
[...]
> > - Remove useless packages:
> > + icc-utils
> > Now in argyll. Now only dummy package.
>
> Please mention "(transitional package)" in the package's short description,
> and perhaps also in the long description ("This package is a transitional
> dummy package." instead of "This package is a dummy package.")
>
done
[...]
> > * Add debian/source/options:
> > - Set compression to xz & compression-level to 9 to save space.
>
> xz is now the default, and 9 is too expensive at decompression-time for some
> of the smaller devices where argyll can be useful (think of small ARM boards
> driving televisions). It might be better just to remove debian/source/options
> entirely...
>
d/source/options removed. Also the changlog entry.
> > * debian/copyright:
> > - Rewrite into DEP-5 format.
> > - Add myself to the list of authors for debian/*.
> > - Add missing licenses and authors.
>
> A few comments on debian/copyright:
> * "Aladdin Enterprices" should be "Aladdin Enterprises"
> * usb/driver/* should be "License: GPL-2 or LGPL-2" since the licenses aren't
> cumulative
> * "Richaerd Hughes" should be "Richard Hughes"
> * you could say "License: libjpeg" instead of "License: other" for jpg/*
>
Typos corrected and the two License rewritten.
[...]
> > * debian/patches/
> > - New 110_dispwin_segfault.patch to prevent segfault by
> > wrong parameter (Closes: #700253)
>
> I see other patches as well... 15_jam.patch.org should be removed, along
> with the various patches which are no longer used in the series file (and
> you should clean up the series file too). In 110_dispwin_segfault.patch, is
> there a link to the mailing list archives you could copy in the "Forwarded"
> item?
Link is included. Useless patches deleted and from d/p/series removed.
>
> Regards,
>
> Stephen
CU
Jörg
--
pgp Fingerprint: 7D13 3C60 0A10 DBE1 51F8 EBCB 422B 44B0 BE58 1B6E
pgp Key: BE581B6E
CAcert Key S/N: 0E:D4:56
Jörg Frings-Fürst
D-54526 Niederkail
Threema: SYR8SJXB
IRC: j_f-f@freenode.net
j_f-f@oftc.net
Attachment:
signature.asc
Description: This is a digitally signed message part