[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#747032: RFS: libjs-zxcvbn/1.0+dfsg.1-1



2014-09-10 19:15 GMT-03:00 Ben Finney <ben+debian@benfinney.id.au>:
> On 09-Sep-2014, Eriberto Mota wrote:
>> About your package, please:
>
> Thank you for reviewing and providing feedback on this package.


I am glad to help you.


>> 2. d/control: in short description there is an 'indent' signal.
>> Please, change to a simple dash. Do the same in d/copyright.
>
> I don't know what “indent signal” is. Are you referring to a
> punctuation character?
>
> All the control files in a Debian source package are Unicode
> <URL:https://www.debian.org/doc/debian-policy/ch-controlfields.html>,
> so as far as I can tell these control fields can contain any
> appropriate punctuation.
>
> Is there some other problem with these fields?


Sorry but I am not English native. I will try explain using the
characters. I would like that you to change "—" by "-".


>> 3. d/copyright: there are files licensing to other authors that not
>> Dropbox. Please, review carefully all files. As help, use 'grep
>> -sriA25 copyright *'.
>
> Thank you, I will look more closely and update the copyright
> information.


Ok!


>> 4. Your package doesn't build in my machine. It stops showing '( cd
>> scripts && python "build_frequency_lists.py" )' in screen.
>
> You later appeared to get further in the build process. Is this still
> a problem for you?


No. When downloading, the screen activities stop some time. So, I
waited more time and I saw the package building.


> On 10-Sep-2014, Eriberto Mota wrote:
>> I did new tests and the package, when building, downloads lots of
>> files from http://en.wiktionary.org/wiki/Wiktionary.
>>
>> The download files at build time is discouraged […]
>
> I agree with these reasons. Do you have a different approach which
> would avoid generated files in the source package without
> corresponding source?
>
> I would like to find a solution that improves the upstream package and
> doesn't bundle sourceless data files, but upstream are not responsive
> to discussing these improvements. Maybe I'll need to host a fork
> myself.

I think that there are four solutions (maybe you will need ask about
it in debian-legal, maybe no):

1. If the license permit, you can package the files from
http://en.wiktionary.org/wiki/Wiktionary. However I have doubts if you
can do it (gather all files in a tarball and package it).

2. You can make a package that shows an notification to user and
downloads the files via postinst script. The site must allow it. I
think that this package will be contrib[1].

3. You can write a d/README.Debian to instruct the final user to
download and install the files.

4. You can do a complete fork in GitHub.

[1] https://www.debian.org/doc/debian-policy/ch-archive.html#s-contrib

Good night from Brazil!

Cheers,

Eriberto


Reply to: