[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#747032: RFS: libjs-zxcvbn/1.0+dfsg.1-1



On 09-Sep-2014, Eriberto Mota wrote:
> About your package, please:

Thank you for reviewing and providing feedback on this package.

> 2. d/control: in short description there is an 'indent' signal.
> Please, change to a simple dash. Do the same in d/copyright.

I don't know what “indent signal” is. Are you referring to a
punctuation character?

All the control files in a Debian source package are Unicode
<URL:https://www.debian.org/doc/debian-policy/ch-controlfields.html>,
so as far as I can tell these control fields can contain any
appropriate punctuation.

Is there some other problem with these fields?

> 3. d/copyright: there are files licensing to other authors that not
> Dropbox. Please, review carefully all files. As help, use 'grep
> -sriA25 copyright *'.

Thank you, I will look more closely and update the copyright
information.

> 4. Your package doesn't build in my machine. It stops showing '( cd
> scripts && python "build_frequency_lists.py" )' in screen.

You later appeared to get further in the build process. Is this still
a problem for you?


On 10-Sep-2014, Eriberto Mota wrote:
> I did new tests and the package, when building, downloads lots of
> files from http://en.wiktionary.org/wiki/Wiktionary.
> 
> The download files at build time is discouraged […]

I agree with these reasons. Do you have a different approach which
would avoid generated files in the source package without
corresponding source?

I would like to find a solution that improves the upstream package and
doesn't bundle sourceless data files, but upstream are not responsive
to discussing these improvements. Maybe I'll need to host a fork
myself.

-- 
 \          “I moved into an all-electric house. I forgot and left the |
  `\   porch light on all day. When I got home the front door wouldn't |
_o__)                                            open.” —Steven Wright |
Ben Finney <ben@benfinney.id.au>

Attachment: signature.asc
Description: Digital signature


Reply to: