Bug#741648: RFS: cbootimage/1.2-2
2014-09-04 18:15 GMT-03:00 Marc Dietrich <marvin24@gmx.de>:
> Hi Eriberto,
Hi Marc,
>> 3. d/control: you need a VCS to control your packaging. I think that
>> already told you about it. Ask me if you have doubt.
>
> Yes, I original got it wrong thinking it must be the upstream repo. Since I
> have no repo for the debian stuff (and I really don't like to create one) I
> just dropped it because it is neither mandatory nor recommended.
Not mandatory or recommended by policy. However, a good practice
commonly requested by all sponsors to allow the control of the code by
you or any external people. You must implement it.
>> 4. d/copyright: you need remake this file. A short example is that you
>> didn't told about build/* directory. Please, read (really) about
>> 'copyright' here[1]. As a tip, if your main upstream is Nvidia, you
>> can use a general reference to it. An example (not real for years
>> range):
>
> Ah, I forgot to update it to the new paths. In fact, the files are copyrighted
> by different people from different companies, so I like to keep the current
> style of one copyright line per company. The NVIDIA copyright mostly comes
> from the "buildsystem" and their own boards.
You must review each file. Use 'grep -sriA25 copyright *' to help you.
I checked each file and FTP Master will do it too. I found several
issues. Some examples:
- There are several files copyrighted as 2012-2013, or 2012, or 2013
for CompuLab Ltd. You wrote 2012 only.
- I didn't saw copyrights for Toradex in your file.
- 2011-2013 for Avionic Design GmbH. You wrote 2013 only.
- Other issues.
Please, change tegra*/compulab/* for two blocks: tegra20/compulab/*
and tegra30/compulab/*:
Files: tegra20/compulab/*
Copyright: xyz
License: abc
Files: tegra30/compulab/*
Copyright: xyz
License: abc
Do the same to tegra*/toradex/* and tegra*/avionic-design/*. It will
avoid confusion and make easier a future upgrade.
The 'Files: tegra*/nvidia/* build/*' must be 'Files: *'.
Finally, please, INSPECT all files. It will make my work easier.
>> 5. d/docs: you is installing ALL files as documents. No! There is one
>> document only: README.txt. The other files are your program.
>
> These files are not really required for cbootimage to run. They are more like
> examples on how to write a configuration. They even have their own buildsystem
> so the user needs to copy them to his own directory to actually use them. As
> the whole package only contains examples, they can go directly into docs
> (without docs/example) [2]. The user feeds the path to the generated config
> file to the cbootimage program. You can see it as a "configuration compiler".
>
> [2] https://www.debian.org/doc/debian-policy/ch-docs.html#s12.6
Ok. I understood now. But your d/control don't explain about it. So
you must adapt the long description.
You are putting files as build.sh and Makefile. They aren't examples.
So, you must remove these files or put all files in /usr/share/[...]
(it is usual in Debian). In this case, you can write an
d/README.Debian to explain about the files in /usr/share.
Note that the current package is generating this Lintian message:
X: cbootimage-configs: duplicate-files
usr/share/doc/cbootimage-configs/tegra114/nvidia/dalmore/build.sh
usr/share/doc/cbootimage-configs/tegra124/nvidia/jetson-tk1/build.sh
usr/share/doc/cbootimage-configs/tegra124/nvidia/venice2/build.sh
usr/share/doc/cbootimage-configs/tegra20/avionic-design/medcom-wide/build.sh
usr/share/doc/cbootimage-configs/tegra20/avionic-design/plutux/build.sh
usr/share/doc/cbootimage-configs/tegra20/avionic-design/tec/build.sh
usr/share/doc/cbootimage-configs/tegra20/compulab/trimslice/build.sh
usr/share/doc/cbootimage-configs/tegra20/nvidia/harmony/build.sh
usr/share/doc/cbootimage-configs/tegra20/nvidia/seaboard/build.sh
usr/share/doc/cbootimage-configs/tegra20/nvidia/ventana/build.sh
usr/share/doc/cbootimage-configs/tegra20/nvidia/whistler/build.sh
usr/share/doc/cbootimage-configs/tegra20/toradex/colibri-t20/build.sh
usr/share/doc/cbootimage-configs/tegra30/avionic-design/tec-ng/build.sh
usr/share/doc/cbootimage-configs/tegra30/nvidia/beaver/build.sh
usr/share/doc/cbootimage-configs/tegra30/nvidia/cardhu/build.sh
usr/share/doc/cbootimage-configs/tegra30/toradex/colibri_t30/build.sh
If you use the /usr/share/cbootimage-configs, the message will stop.
I read quickly the README.txt and I saw that cbootimage will need of
extracted files from NVidia hardware, right? If yes, I think that
NVidia hardware content isn't free. So, if confirmed, cbootimage must
be put in 'contrib'.[1]
[1] https://www.debian.org/distrib/packages#note
>> 6. d/rules: your rules has useless comments and is wrong. But your
>> package is building documents only. So, I can't comment about d/rules
>> yet. You need read about the upstream program (where put it). I think
>> that you need all cfg files in /usr/share/cbootimage-configs to make a
>> link from cbootimage.
>
> see above.
You needn't of the 'export DH_OPTIONS'.
Please, reply to all (I and the RFS bug). Thanks.
Cheers,
Eriberto
Reply to: