Bug#758646: RFS: ryu/3.12-1 [ITP]
Thanks a lot Dariusz.
Cheers,
Eriberto
2014-08-27 15:51 GMT-03:00 Dariusz Dwornikowski
<dariusz.dwornikowski@cs.put.poznan.pl>:
>> Hi!
>>
>> A last issue...
>>
>> I think that there a mistake in d/copyright. You removed the original
>> debian/ when you generated the tarball and remade the debian/
>> structure. So, I think you must remove the upstream name from debian/*
>> in d/copyright and should add a d/README.source to explain about the
>> original debian/ remotion.
>>
>> I will wait your opinion.
>>
>
> I will leave them there because some of things they have done I kept.
>
> I think that explaining removal of debian/ is not neccessary. It is
> generally done out of the box by git-import-orig anyways. But
> personally I think it does not hurt, I added the explanation as you
> suggested.
>
> The new version is in mentors.
>
>>
>>
>> 2014-08-27 3:40 GMT-03:00 Dariusz Dwornikowski
>> <dariusz.dwornikowski@cs.put.poznan.pl>:
>> >> Hi Dariusz, how are you?
>> >>
>> >> Please:
>> >>
>> >> 1. d/clean: you package doesn't build twice because the d/clean
>> >> removes files only (not directories - man dh_clean). :-P
>> >>
>> >> I saw you are using an override in d/rules to remove files. Why you
>> >> need a d/clean?
>> >
>> > I fixed that, now it is onlu in d/rules. I use git-buildpackage, my
>> > build area is in a different place, so for me the package always built
>> > cleanly twice.
>> >
>> >>
>> >> 2. d/control: in short descriptions, remove the program name and put
>> >> each designation between brackets. My suggestion:
>> >>
>> >> Description: defined networking framework (Python libs)
>> >> Description: defined networking framework (ryu binary)
>> >> Description: defined networking framework (docs)
>> >
>> > Great advice, I followed it.
>> >
>> >>
>> >> You can change it.
>> >>
>> >> 3. d/copyright:
>> >> - debin? :-D
>> >> - Please, review all source code carefully. I didn't see the
>> >> 'Nippon Telegraph and Telephone Corporation' in your d/copyright.
>> >
>> > Yes, I updated the copyright, also did som clarification on a "weird"
>> > license I encoutered inside on debian-legal@ [1].
>> >
>> >>
>> >> 4. d/docs: I think that this file is a mistake because you created the
>> >> python-ryu-doc.docs. Am I wrong?
>> >>
>> >
>> > You are not wrong mister :) I deleted the docs file.
>> >
>> >> 5. d/ryu-bin.ryu.init: please, remove all useless lines as "Add code
>> >> here, if necessary,...".
>> >
>> > I deleted not needed comments.
>> >
>> >>
>> >> 6. d/ryu.conf: I think it is confused. Can you add comments to help
>> >> the user? Please, adopt a format to commented lines (# with spaces or
>> >> # without spaces).
>> >
>> > Did some research on this, kept only options needed to run basic ryu
>> > and commented them. I deleted options connected to OpenStack, if
>> > someone wants to run OpenStack with ryu, they should use OpenStack's
>> > doc howto do it, not ryu's.
>> >>
>> > [1] https://lists.debian.org/debian-legal/2014/08/msg00073.html
>> >
>> >
>> > I uploaded the new version to mentors.
>> >
>> > --
>> > Dariusz Dwornikowski,
>> > Institute of Computing Science, Poznań University of Technology
>> > www.cs.put.poznan.pl/ddwornikowski/
>> > room 2.7.2 BTiCW | tel. +48 61 665 29 41
>
> --
> Dariusz Dwornikowski,
> Institute of Computing Science, Poznań University of Technology
> www.cs.put.poznan.pl/ddwornikowski/
> room 2.7.2 BTiCW | tel. +48 61 665 29 41
Reply to: