Hi Eriberto, On 20.08.2014 23:13, Eriberto Mota wrote: > 1. d/copyright: remove build/ltmain.sh. This file needn't be put (read the > license). Are you sure? Don't I still have to name the copyright holder? removed it for now. > 2. d/libgtkspellmm-3.0-dev.install > > From Maintainers Guide[1]: > > Shared libraries are distributed as *.so files. (Neither *.a files nor *.la > files) > > [1] https://www.debian.org/doc/manuals/maint-guide/advanced.en.html > > So, remove all .a and .la references. Remove the .so and make a synlink to .so > created by libgtkspellmm-3.0-0.install (create a d/libgtkspellmm-3.0-dev.links > file). (NEWS: after a debuild, I saw that the Makefile created the symlink - > check if is ok) OK, removed .a and .la references. .so is installed by libgtkspellmm-3.0-dev.install > 3. d/rules: - Remove the dh_install override. - Why you used '--enable-static'? > Is possible remove it? I think you can remove all override_dh_auto_configure. Removed it > 4. d/libgtkspellmm-3.0-0.shlibs: what is the function of this file? I think you > can remove it. If I provide a symbol file yes -> removed. For the shlibs system see: https://www.debian.org/doc/debian-policy/ch-sharedlibs.html#s-sharedlibs-shlibdeps >>> I: libgtkspellmm-3.0-0: no-symbols-control-file [...] >> >> I tried to generate one but I'm really not sure how useful this is as I'm not >> very experienced with libraries. (And even Russ Allbery gave up on C++ symbol >> files[1].) > > > Ok. You must run 'debuild' and, after this, in the upstream code place, you > use: > > # dpkg-gensymbols -plibgtkspellmm-3.0-0 -Odebian/libgtkspellmm-3.0-0.symbols > > After this, edit the generated file and remove all Debian revisions (-1). I did this but wasn't sure how useful it is. Included it now and removed the +dfsg-1 part. I also applied C++ filter to make it a little more readable. >> [1] http://www.eyrie.org/~eagle/journal/2012-02/001.html >> >>> X: libgtkspellmm-3.0-doc: duplicate-files [...] >> >> That's a Doxygen issue and I guess it's better to fix that in Doxygen and >> not introducing ugly workarounds in all packages using it. >> > > > Hum... These files have the same hash... Is possible delete one of each double? > If not, you can delete one and add a synlink or... Put an override with a line > explaining the problem. Added an override. I uploaded the package again to m.d.n (should be available in some minutes): http://mentors.debian.net/package/gtkspellmm Thanks for all your review work! Best, Philip
Attachment:
signature.asc
Description: OpenPGP digital signature