Hi Eriberto,
On 18.08.2014 22:06, Eriberto Mota wrote:
> Hi Philip,
>
> In gimagereader, please:
>
> 1. Fix this Linitian message: desktop-entry-lacks-keywords-entry
Added a patch for that. Although I was not too creative with my keywords.
> 2. Create a VCS to control your /debian versions. You can use github
> or other. So, add the Vcs-Browser and Vcs-{Git|Svn|Cvs} to d/control.
Ups, forgot that, added them now. It's at
http://anonscm.debian.org/gitweb/?p=collab-maint/gimagereader.git;a=summary
> 3. d/control: please, in long description, put one or two lines
> explaining what is tesseract. Use punctuation in phrases.
Added information about tesseract and rephrased the whole description.
> 4. d/copyright:
>
> - Change from '2009-2013, Canonical Ltd' to 'Copyright (C)
> 2009-2013 Canonical Ltd., by Robert Ancell
> <robert.ancell@canonical.com>'.
> - Use GPL-3+ in debian/*. Your package is a derivative work and
> GPL3 is incompatible with GPL2. [1]
> - You need write the license using the FSF rules [2]. An example here[3].
>
>
> [1] http://www.gnu.org/licenses/gpl-faq.html#v2v3Compatibility
> [2] http://www.gnu.org/licenses/gpl-howto.html
> [3] http://metadata.ftp-master.debian.org/changelogs/main/g/gconjugue/unstable_copyright
Updated it according to your hints, thanks.
> 5. d/docs: you must install the documents that are useful to final
> users. So, remove AUTHORS. It must be put in d/copyright only.
Done, I also removed TODO as it's more for devs.
> 6. d/rules:
> - Comment the verbose line.
Did that now, forgot while debugging the hardening issues.
> - Add 'export V=1' to show all compiler flags. If you want read
> about it, $ man blhc.
>
> The lintian shows a message about hardening. But, for the first time
> in my life, i think that it is a false positive. The flags are in
> Makefile and 'blhc --all' doesn't show warnings.
That was my approach too, thanks for the hint.
> 7. d/watch: to allow downloads, point to 'releases' instead 'tags'.
Worked for me with 'tags' as well but 'releases' is probably what I want.
> Thanks for your work.
Thanks for your fast review!
I updated the files on m.d.n: http://mentors.debian.net/package/gimagereader
Best,
Philip
Attachment:
signature.asc
Description: OpenPGP digital signature