Bug#745777: RFS: ipad-charge/0~20131118.c82b032-1 [ITP] -- USB charging control utility to charge an Apple device
tags 745777 moreinfo
thanks
Hi Benjamin,
Please,
1. The upstream doesn't put a tag in repository (GitHub). In this
case, the program not have an official version. So, you must use 0.0
as version, the date and Git commit as version (or other similar
format). An example:
0.0~git20140314.938cf1. In your case: 0.0~git20131118.c82b03 (the last
commit). To see more examples: $ dpkg -l | grep -i git.
2. In d/control:
- Change the priority from extra to optional.
- The Vcs-* must be used to add a VCS that control your
packaging, not the upstream code only.
3. d/copyright: update the years. There is code commited in 2013.
There is no indication in the code about GPL-2.0 or GPL-2.0+. So, use
GPL-2.0.
4. d/docs: no relevant information for final user. I suggest you
remove this file and create a README.Debian to say the Wiki URL.
5. d/rules: remove this useless text:
# -*- makefile -*-
# Sample debian/rules that uses debhelper.
# This file was originally written by Joey Hess and Craig Small.
# As a special exception, when this file is copied by dh-make into a
# dh-make output file, you may use that output file without restriction.
# This special exception was added by Craig Small in version 0.37 of dh-make.
# Uncomment this to turn on verbose mode.
6. d/watch: not working. Please, see it: http://eriberto.pro.br/blog/?p=1459
7. There are Lintian messages:
W: ipad-charge: hardening-no-relro usr/bin/ipad-charge
I: ipad-charge: hardening-no-fortify-functions usr/bin/ipad-charge
To fix, see:
- https://wiki.debian.org/Hardening
- http://sources.debian.net/src/mac-robber/1.02-2/debian/patches/Makefile.patch
W: ipad-charge: binary-without-manpage usr/bin/ipad-charge
You need to write a manpage. You can use txt2man to make it easier.
See an example here:
http://sources.debian.net/src/mac-robber/1.02-2/debian/man
Thanks for your work.
Regards,
Eriberto
2014-04-29 3:44 GMT-03:00 Dariusz Dwornikowski
<dariusz.dwornikowski@cs.put.poznan.pl>:
>
> Hi Benny,
>
> I am not a DD, I cannot sponsor your package but here are some
> comments:
>
> Since it is your initial upload, the version should be -1, you bump
> the number only when you *release* a new package. Merge all the
> changes into 1.1-1 release.
>
> Other things to fix:
>
> - set homepage field in d/control to github project page
> - standards should be 3.9.5
> - make the package depend on debhelper >= 9 in d/control
> - when upstream releases on github, you can prepere a watch file,
> something like that should be sufficient:
>
> version=3
> https://github.com/mkorenkov/ipad_charge/releases .*/archive/v(\d[\d\.]+)\.tar\.gz
>
> - in d/copyright you did not add years to Files: *
> - patches are not described according to DEP-3 [1]
> - what about udev rules ? are they installed ?
> - did you check your package with pbuilder and/or piuparts ?
>
> We can review the package once more, when you fix.
>
> [1] http://dep.debian.net/deps/dep3/
>
> --
> Dariusz Dwornikowski,
> Institute of Computing Science, Poznań University of Technology
> www.cs.put.poznan.pl/ddwornikowski/
> room 2.7.2 BTiCW | tel. +48 61 665 29 41
>
>
> --
> To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
> with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org
> Archive: https://lists.debian.org/20140429064420.GA2950@blackstar.cs.put.poznan.pl
>
Reply to: