Control: tags -1 +pending -moreinfo Hi Yavor, On 06-08-14 13:25, Yavor Doganov wrote: >> I find the man page rather short, is it reasonable to improve it? > > I have extended it as much as I could. Looks much better now, thanks. >> I didn't check yet, but aren't you know installing the d/docs adn >> d/examples files into all packages? Is that what you want? > > They're installed only in the gorm.app package which is what I want. Yes, sorry, as I said, I hadn't checked yet. >> Did you already forwarded your patches? > > No; link-libs will be rejected (for some reason upstream considers it > a feature not to link the dynamically loadable modules), so I have to > rework it somehow. Regarding texinfo-fixes, I'd like to fix more > (minor) issues before forwarding upstream but have postponed that as > there are currently more important problems to deal with. Again, as I have said before, it might be nice to document such things in the header so it is clear for everybody. > Could you please post the error message? Please see below: paul@wollumbin ~/tmp/sponsorships/gorm.app $ TEST=lintian pdebuild dpkg-checkbuilddeps: Unmet build dependencies: libgnustep-gui-dev cm-super-minimal W: Unmet build-dependency in source dpkg-buildpackage: source package gorm.app dpkg-buildpackage: source version 1.2.20-1 dpkg-buildpackage: source changed by Yavor Doganov <yavor@gnu.org> dpkg-source --before-build gorm.app dpkg-checkbuilddeps: Unmet build dependencies: libgnustep-gui-dev cm-super-minimal dpkg-buildpackage: warning: build dependencies/conflicts unsatisfied; aborting dpkg-buildpackage: warning: (Use -d flag to override.) dpkg-buildpackage: warning: this is currently a non-fatal warning with -S, but will probably become fatal in the future fakeroot debian/rules clean dh clean dh_testdir dh_auto_clean debian/rules override_dh_clean make[1]: Entering directory `/media/home/paul/tmp/sponsorships/gorm.app' /usr/bin/make -C Documentation distclean make[2]: Entering directory `/media/home/paul/tmp/sponsorships/gorm.app/Documentation' GNUmakefile:2: /common.make: No such file or directory GNUmakefile:30: /documentation.make: No such file or directory make[2]: *** No rule to make target `/documentation.make'. Stop. make[2]: Leaving directory `/media/home/paul/tmp/sponsorships/gorm.app/Documentation' make[1]: *** [override_dh_clean] Error 2 make[1]: Leaving directory `/media/home/paul/tmp/sponsorships/gorm.app' make: *** [clean] Error 2 dpkg-buildpackage: error: fakeroot debian/rules clean gave error exit status 2 > Any errors should be ignored by gnustep-make by default. Might it be that not gnustep-make is used? > Adding a hyphen triggers a lintian warning, so I've added a check for > the presence of the .info file instead. Sure, I saw the same after I posted. >> Most importantly, I am not convinced yet, that the debian/copyright file >> is a proper description of the situation. Some items that I saw and I >> like clarification for: >> + in the README: Icons - Mostly by Andrew Lindsay. Gorm application >> icon by Jesse Ross. Code - GormViewKnobs.m adapted from code by Gerrit >> van Dyk. > > I cannot put this in debian/copyright as that file should document > copyright, not authorship. Gorm is an official GNU package and > copyright is assigned to the FSF. Ack. >> + GormImageInspector/GormNSSplitViewInspector and many more contain the >> header "All Rights reserved". Please check with upstream. > > These files are most probably instantiated with Gorm itself which puts > this notice. I'll ask upstream to replace it with the actual license > notice. "All rights reserved" has no legal weight anyway. Thanks. >> + Documentation/COPYING and most GNUmakefiles say GPL-2+ > > The former is correct. Apparently most makefiles were omitted during > the switch to GPL-3+. I'll ask upstream to rectify this. Ack. >> The d/copyright file mentions Examples/* but that does not exist in the >> root. So, what do you mean. > > Thanks, it should have been Documentation/Examples/*. Fixed. Thought so. Thanks. I have already build the binary and I will upload as-is, but lintian also warns me about a spelling error: I: gorm.app: spelling-error-in-binary usr/lib/gorm.app/libGormCore.so.1.2.20 Recieved Received And I saw that several document seem to be double installed, e.g.: ./usr/share/GNUstep/Documentation/README ./usr/share/doc/gorm.app/README and ./usr/share/GNUstep/Documentation/NEWS ./usr/share/doc/gorm.app/NEWS.gz Maybe it makes sense to install everything under /usr/share/GNUstep/Documentation/ into /usr/share/doc/gorm.app and creating a softlink from one to the other, as Debian users expect to find the documentation in the /usr/share/doc location while GNUstep users might look in the other location. Paul
Attachment:
signature.asc
Description: OpenPGP digital signature