[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756451: marked as done (RFS: libcgroup/0.41 [ITA] -- control and monitor control groups)

Your message dated Sun, 3 Aug 2014 19:50:06 -0700
with message-id <CACZd_tA_DJ5DxMe=eLnB5_C12t+MAatCKWncy34FUurxtOJ1Cg@mail.gmail.com>
and subject line Re: Bug#756451: RFS: libcgroup/0.41 [ITA] -- control and monitor control groups
has caused the Debian Bug report #756451,
regarding RFS: libcgroup/0.41 [ITA] -- control and monitor control groups
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
756451: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756451
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for a new version of package libcgroup. It
builds the following binary packages:

  cgroup-bin - control and monitor control groups (transitional package)
  cgroup-tools - control and monitor control groups (tools)
  libcgroup-dbg - control and monitor control groups (debug)
  libcgroup-dev - control and monitor control groups (development)
  libcgroup1 - control and monitor control groups (library)
  libpam-cgroup - control and monitor control groups (PAM)

The package builds lintian-clean with sbuild. The source package can be
found here:

    http://www.kvr.at/debian/pool/main/libc/libcgroup/libcgroup_0.41-5.dsc

Changes since the last revision:
  * debian/control:
    - Set myself to new maintainer. Closes: #756092
    - Use versioned Breaks instead of Conflicts
    - Update Vcs- fields to collab-maint
    - Drop redundant Section
    - Add Multi-Arch fields
  * debian/patches (refreshed):
    - Update headers of existing patches to play more nicely with gbp-pq
  * debian/watch:
    - Create watch file
  * debian/copyright:
    - Added myself
  * debian/patches (added):
    - 0005-Syntax-fixes-for-man-pages

--- End Message ---
--- Begin Message --- 
Hi Christian,

On Sun, Aug 3, 2014 at 5:56 AM, Christian Kastner <debian@kvr.at> wrote:
> On 2014-08-03 12:11, Christian Kastner wrote:
>>> debian/copyright:
>>> - src/pam/pam_cgroup.c is dual-licensed BSD and LGPL 2.1, not BSD or
>>> GPL 2. That also makes the GPL-2 license block in d/copyright
>>> obsolete.
>>
>> Hm... while you're right that something is off, the way I read it, it's
>> mostly (BSD or GPL-2), to which LGPL-2.1 code was added. Therefore, I
>> updated the License specification and added a standalone block for the
>> LGPL-2.1.
>>
>> Side note: it's unclear from the license text and context of this file
>> which version of the GPL is spoken of, but tracing the original code it
>> can be seen that it really is the GPL-2.
>
> Addendum: I found it strange that the additions to this file were
> described as LGPL-2.1, whereas the rest was supposed to be LGPL-2.1+.
>
> It turns out that everything else has always been LGPL-2.1, too.
> Upstream ships the full license text, but the individual source files
> omit the "[...] or any later version" qualification.
>
> As this is a more serious error, I filed #756915 to document this properly.
>
> A new package with a fix has been prepared at the previously posted
> locations.

Ok, looks good.

I just wanted to point out that the orig tarball your .dsc points to
has a different size than the current libcgroup orig tarball in
Debian, i.e.

dpkg-source: error: file ./libcgroup_0.41.orig.tar.xz has size 406136
instead of expected 405104

I'm going to assume that you didn't actually intend to modify the
tarball, and build the package with the current orig tarball in the
archive instead of yours. If that's not the case, make sure you change
the upstream version number in your next upload (otherwise dak will
reject the upload) and provide rationale for modifying the tarball.

A few more todo's that you may want to look at, at some point in the
future (none of these are blockers / urgent):
- debian/rules: figure out why test suite is disabled / enable them if
possible; override_dh_builddeb target is obsolete
- debian/copyright: prefer the SPDX names for the licenses that you're
using, i.e. "BSD-3-clause" instead of just "BSD"
- debian/cgroup-tools.TODO

(and update collab-maint too, of course)

Built, signed, and uploaded; thanks for your contribution to Debian!

Regards,
Vincent

--- End Message ---
Reply to: