Bug#754793: RFS: mosquitto/1.2.1-2 RC

[Eriberto <eriberto@eriberto.pro.br>]

2014-08-01 19:18 GMT-03:00 Roger Light <roger@atchoo.org>:

> Thanks for taking the time to start a review.


Hi Roger! You're welcome.


>> 4. All readmes should be put in /usr/share/doc/mosquitto. Do you have
>> a reason to put them in /etc?
>
> These READMEs are simple explanations of empty directories, it doesn't
> make sense to put them in share/doc in my opinion. I'm following the
> example of packages such as sysv-rc, udev, sudo, grub, lighttpd,
> procps that all do this.


Ok. I don't like it. But you have examples and I will accept. But I
don't intend accept it in new packages for other maintainers. But your
package already in Debian and you won. :-)


>> 6. There is a .conf in /etc/init. What is this?
>
> This is an upstart config file as Cameron already mentioned.

Ok! New for me. I need learn/understand it better. :-)


My new (and last, I think) observations:

1. You need to put all changes in d/changelog. You can use your VCS to check it.

2. In d/changelog, you should use urgency=medium, not high.

3. The cowbuilder builds the package. However, when building the
package in a new Sid environment (new, recently installed, clean), I
got:

./01-connect-success.py
1407017636: Error: Invalid user 'mosquitto'.

Traceback (most recent call last):
  File "./01-connect-success.py", line 29, in <module>
    sock = mosq_test.do_client_connect(connect_packet, connack_packet)
  File "/root/sponsor/mosquitto-1.3.3/test/mosq_test.py", line 32, in
do_client_connect
    sock.connect((hostname, port))
  File "/usr/lib/python2.7/socket.py", line 224, in meth
    return getattr(self._sock,name)(*args)
socket.error: [Errno 111] Connection refused
Makefile:15: recipe for target '01' failed
make[3]: *** [01] Error 1
make[3]: Leaving directory '/root/sponsor/mosquitto-1.3.3/test/broker'
Makefile:15: recipe for target 'test' failed
make[2]: *** [test] Error 2
make[2]: Leaving directory '/root/sponsor/mosquitto-1.3.3/test'
Makefile:31: recipe for target 'test' failed
make[1]: *** [test] Error 2
make[1]: Leaving directory '/root/sponsor/mosquitto-1.3.3'
dh_auto_test: make -j1 test returned exit code 2
debian/rules:7: recipe for target 'build' failed
make: *** [build] Error 2


I think it is a code issue. If I create the user "mosquitto", the
package builds. I need an explanation about it, please.

I will wait you.

Regards,

Eriberto