Bug#754793: RFS: mosquitto/1.2.1-2 RC
Hi Eriberto,
Thanks for taking the time to start a review.
> 1. Update the Standards-Version from 3.9.4 to 3.9.5.
Done
> 2. d/copyright: please, update the years (include 2014, because I
> found it in your upstream code).
Done.
> 3. d/docs: The final user doesn't compiles codes. So, send compiling
> instructions to user is unusual. Please, remove the compiling.txt.
Yes, that makes complete sense. Removed.
> 4. All readmes should be put in /usr/share/doc/mosquitto. Do you have
> a reason to put them in /etc?
These READMEs are simple explanations of empty directories, it doesn't
make sense to put them in share/doc in my opinion. I'm following the
example of packages such as sysv-rc, udev, sudo, grub, lighttpd,
procps that all do this.
> 5. The example must be put in /usr/share/doc/mosquitto/examples ($ man
> dh_installexamples).
I have fixed this.
> 6. There is a .conf in /etc/init. What is this?
This is an upstart config file as Cameron already mentioned.
I've uploaded a new version (actually this is now upstream version
1.3.3) to mentors.
Thanks again,
Roger
Reply to: