Bug#751534: RFS: crunch/3.6-1 [ITP] -- tool for creating wordlist

[Jakub Wilk <jwilk@debian.org>]

* Jakub Wilk <jwilk@debian.org>, 2014-06-25, 21:35:
> > I put now GPL-2.0+ in debian/copyright
> But that's not what upstream says. They say explicitly “version 2 only 
> of the License”.

Ping? I can't upload a package with incorrect d/copyright.


GCC emits these warnings:

crunch.c: In function 'main':
crunch.c:2999:5: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
    fgets(response,8,stdin);
    ^
crunch.c: In function 'resumesession':
crunch.c:2199:7: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
      (void)fgets(buff, (int)sizeof(buff), optr);
      ^
crunch.c: In function 'renamefile':
crunch.c:1476:7: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
      (void)fgets(buff, (int)sizeof(buff), optr);
      ^
crunch.c:1479:9: warning: ignoring return value of 'fgets', declared with attribute warn_unused_result [-Wunused-result]
        (void)fgets(buff, (int)sizeof(buff), optr);
        ^

I see that upstream explicitly throws away return value of some fgets(3) 
calls, but I don't think it's right. fgets() can fail, and such failure 
should not be ignored. Please nudge upstream about this problem.

--
Jakub Wilk