On 01/06/14 03:47, Paul Wise wrote: > On Sat, May 31, 2014 at 1:37 AM, Carlos Alberto Lopez Perez wrote: > >> dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.2-0~beta3-1.dsc > > Some comments below. Other comments via private mail. > > Upstream website SSL is broken because it doesn't send CA certs along > with it, they need to use SSLCertificateChainFile. Also cacert.org > isn't trusted by many browsers or CA cert stores so it probably isn't > the best choice. > > https://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcertificatechainfile > I will forward your comments regarding the SSL certificate of aircrack-ng.org to Thomas. > I would suggest using experimental instead of unstable for betas. > In general I agree with you, but this release is IMHO an improvement over the previous 1.1 series and is as stable as the older one. I think that Thomas should have called it release candidate instead of beta. Most probably, the final 1.2 version would be very similar to this one. Also I wouldn't want it to miss the next stable release of Debian. Previous 1.1 version don't has proper support for libnl, which causes some problems on modern kernels. > Why remove airdriver-ng? > Because is completely broken and only manages to confuse users. Please check: http://trac.aircrack-ng.org/ticket/1317 > Please use dh --parallel to enable parallel building. > Ok. Will add it. > Override_dh_auto_install doesn't need to override the normal make > install, just use dh_auto_install > Ok. > I think you want uversionmangle instead of dversionmangle: > > https://wiki.debian.org/debian/watch#Common_mistakes > Would check it. > Upstream might want to replace evalrev with running autorevision: > > http://packages.debian.org/autorevision > Is there any technical advantage of doing that? Please, feel free to open a ticket on http://trac.aircrack-ng.org > What about enabling ext_scripts? > I tried to do it, but it was such a mess that I decided to go back. * airdrop-ng: depends on pylorcon which is not available on Debian. * versuck-ng: is just a password generator from 2009 for Verizon wireless routers with 64bit WEP Keys. I doubt any user out there is still using this. * airgraph-ng and airoscript-ng: both failed on the install phase. I wasn't able to get them working after a make install. I will gladly accept patches if you are interested in any of this tools. > Are any of the C# things buildable with Mono or useful on Debian? > I have no idea, never tried to build that. The changelog says that it is a C# library to parse Airodump-ng output files. If you know where this can be useful for Debian let me know it. Otherwise I prefer to skip adding a dependency on Mono. > Is upstream working on getting the many patches merged into Linux > mainline? Either way it would be great if they had DEP-3 style patch > headers or similar. > This patches are the ones that airdriver-ng used. 99% of this patches not longer apply or make any sense. See the ticket http://trac.aircrack-ng.org/ticket/1317 I think this patches should be removed from the upstream repository. > airoscript overrides TMPDIR but it should use the user-provided one > and doesn't clean up properly if TMPDIR is not /tmp/. > > It would be good if the airoscript logo files were generated at build > time so they can never get out of sync with the source .xcf/.svg > files. > The package don't installs airoscript (see my previous comments about ext_scripts) I tried to do it, but the install phase is broken (at least for me). Right now I don't have time to fix this, I tried to do it, but it was not a quick fix so I decided to let that for another moment. If you are interested in airoscript-ng I will accept patches to enable it on the Debian package. > Please ask upstream to remove the two prebuilt gettext .mo files from > SVN/tarballs, they should be created at build time > http://trac.aircrack-ng.org/ticket/1436
Attachment:
signature.asc
Description: OpenPGP digital signature