Bug#749929: RFS: aircrack-ng/1:1.2-0~beta3-1
On Sat, May 31, 2014 at 1:37 AM, Carlos Alberto Lopez Perez wrote:
> dget -x http://mentors.debian.net/debian/pool/main/a/aircrack-ng/aircrack-ng_1.2-0~beta3-1.dsc
Some comments below. Other comments via private mail.
Upstream website SSL is broken because it doesn't send CA certs along
with it, they need to use SSLCertificateChainFile. Also cacert.org
isn't trusted by many browsers or CA cert stores so it probably isn't
the best choice.
https://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcertificatechainfile
I would suggest using experimental instead of unstable for betas.
Why remove airdriver-ng?
Please use dh --parallel to enable parallel building.
Override_dh_auto_install doesn't need to override the normal make
install, just use dh_auto_install
I think you want uversionmangle instead of dversionmangle:
https://wiki.debian.org/debian/watch#Common_mistakes
Upstream might want to replace evalrev with running autorevision:
http://packages.debian.org/autorevision
What about enabling ext_scripts?
Are any of the C# things buildable with Mono or useful on Debian?
Is upstream working on getting the many patches merged into Linux
mainline? Either way it would be great if they had DEP-3 style patch
headers or similar.
airoscript overrides TMPDIR but it should use the user-provided one
and doesn't clean up properly if TMPDIR is not /tmp/.
It would be good if the airoscript logo files were generated at build
time so they can never get out of sync with the source .xcf/.svg
files.
Please ask upstream to remove the two prebuilt gettext .mo files from
SVN/tarballs, they should be created at build time
--
bye,
pabs
http://wiki.debian.org/PaulWise
Reply to: