[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#746620: RFS: sxiv/1.2-1




HI Jakub


2014-05-11 14:44 GMT-05:00 Jakub Wilk <jwilk@debian.org>:
* Daniel Echeverry <epsilon77@gmail.com>, 2014-05-10, 14:37:
http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc

Don't put two unrelated changes into a single patch. Could you split allow-cflags-override.diff into two, one for compiler flags, another one for installing icons?

Done!
 

It appears to me that files that are currently installed to /usr/share/sxiv/exec/ are just examples. If this is the case, then they should live in /usr/share/doc/sxiv/examples/.

Done!
 

icon/Makefile needs a “set -e”. Please see Policy §4.6.

Done!

Typo in sxiv.1: existance → existence.

Done!


--
Jakub Wilk



Could you check it out again?
http://mentors.debian.net/debian/pool/main/s/sxiv/sxiv_1.2-1.dsc

Thank you very much!

Regards
 

--
Daniel Echeverry
http://wiki.debian.org/DanielEcheverry
Linux user: #477840
Debian user
Software libre



Reply to: