[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: DEP8 tests using the built package source



Hi Stephen,

On Sat, Mar 29, 2014 at 07:41:29PM +0100, Stephen Kitt wrote:
> > 
> > For sure make is not in @builddeps@ since it is build-essential ... which is
> > actually my point.
> 
> See the documentation:
> 
>     `@builddeps@' will be replaced by the package's Build-Depends:,
>     Build-Depends-Indep:, and "make". This is useful if you have many build
>     dependencies which are only necessary for running the test suite and
>     you don't want to replicate them in the test Depends:. However, please
>     use this sparingly, as this can easily lead to missing binary package
>     dependencies being overlooked if they get pulled in via build
>     dependencies.
> 
> @builddeps@ does include make.

Please explain is that in the python-pysam example this is actually NOT
the case since

$ git diff HEAD^
diff --git a/debian/changelog b/debian/changelog
index 4d6a5e7..7d8f613 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+python-pysam (0.7.5-5) unstable; urgency=medium
+
+  * Add make to autopkgtest dependencies
+    Closes: #741274
+
+ -- Andreas Tille <tille@debian.org>  Wed, 19 Mar 2014 13:30:15 +0100
+
 python-pysam (0.7.5-4) unstable; urgency=medium
 
   * Fix autotest
diff --git a/debian/tests/control b/debian/tests/control
index cfc04fc..f1a4bf7 100644
--- a/debian/tests/control
+++ b/debian/tests/control
@@ -1,3 +1,3 @@
 Tests: run-unit-test
-Depends: @, python-pysam-tests, samtools
+Depends: @, python-pysam-tests, samtools, make
 Restrictions: allow-stderr


this fixed the autotest issue.  Please explain this in connection with your
statement above.
 
Kind regards

       Andreas.

-- 
http://fam-tille.de


Reply to: