[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#736437: marked as done (RFS: phonetisaurus/0.7.8-3 -- Grapheme to Phoneme conversion tool)

Your message dated Sun, 26 Jan 2014 23:50:05 +0100
with message-id <20140126225005.GA27280@jwilk.net>
and subject line Re: Bug#736437: RFS: phonetisaurus/0.7.8-3 -- Grapheme to Phoneme conversion tool
has caused the Debian Bug report #736437,
regarding RFS: phonetisaurus/0.7.8-3 -- Grapheme to Phoneme conversion tool
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
736437: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736437
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: sponsorship-requests
  Severity: wishlist

  Dear mentors,

  I am looking for a sponsor for my package "phonetisaurus"

 * Package name    : phonetisaurus
   Version         : 0.7.8-3
   Upstream Author : Josef Novak <josef.robert.novak@gmail.com>
 * URL             : http://code.google.com/p/phonetisaurus/
 * License         : BSD-2-clause
   Section         : science

  It fixes a bug in phonetisaurus-calculateER.
  I do not think the included patch is relevant to upstream as it does not really solve the issue in the general case. I will inform upstream about the issue and also ask
if it is possible to do anything in order to fix the remaining two pedantic lintian warnings.

  It builds those binary packages:

    phonetisaurus - Grapheme to Phoneme conversion tool

  To access further information about this package, please visit the
following Vcs URL:

 git://anonscm.debian.org/collab-maint/phonetisaurus.git

  Regards,
   Giulio Paci

--- End Message ---
--- Begin Message --- 
* Giulio Paci <giuliopaci@gmail.com>, 2014-01-23, 17:46:

It fixes a bug in phonetisaurus-calculateER.
I do not think the included patch is relevant to upstream as it does not really solve the issue in the general case.
Agreed. Note that there are more hardcoded paths in train-ngramlibrary.py (which we don't ship in the .deb): 

$ grep -Er '[.]/|[^!]/usr' ./script/
./script/train-ngramlibrary.py:        command = "./m2mformat.py PREFIX.m2m.corpus > PREFIX.corpus"
./script/train-ngramlibrary.py:        command = "/usr/local/bin/farcompilestrings --symbols=PREFIXORDER.syms --keep_symbols=1 PREFIX.corpus > PREFIXORDER.far"
./script/train-ngramlibrary.py:    command = "../phonetisaurus-arpa2wfst-omega --lm=PREFIX.arpa > PREFIX.fst"
./script/train-ngramlibrary.py:            command = "./phonetisaurus-calculateER-omega --modelfile PREFIX.fst --testfile g014b2b.test.fix.bsf --prefix PREFIX --decoder_type fsa_eps"
./script/train-ngramlibrary.py:            command = "./phonetisaurus-calculateER-omega --modelfile PREFIX.fst --testfile g014a2.test.tabbed.bsf --prefix PREFIX --decoder_type fsa_eps"
I will inform upstream about the issue and also ask if it is possible to do anything in order to fix the remaining two pedantic lintian warnings. 

s/warnings/tags/


git://anonscm.debian.org/collab-maint/phonetisaurus.git


Uploaded.


Things to fix in the future releases:
* utfcpp is now packaged separately, so it's time to stop using the embedded copy. 

* copyright_hints appears to be outdated:

| WARNING: The following (and possibly more) new or changed notices discovered:
|
|  src/Arpa2Fst.hpp

* Compiler warnings:

Phonetisaurus.cpp:214:9: warning: unused variable 'ip' [-Wunused-variable]
MBRDecoder.cpp:237:32: warning: passing NULL to non-pointer argument 1 of 'void google::dense_hash_map<Key, T, HashFcn, EqualKey, Alloc>::set_empty_key(const key_type&) [with Key = int; T = fst::LogWeightTpl<float>; HashFcn = std::tr1::hash<int>; EqualKey = std::equal_to<int>; Alloc = google::libc_allocator_with_realloc<std::pair<const int, fst::LogWeightTpl<float> > >; google::dense_hash_map<Key, T, HashFcn, EqualKey, Alloc>::key_type = int]' [-Wconversion-null]
MBRDecoder.cpp:698:12: warning: unused variable 'state' [-Wunused-variable]
M2MFstAligner.cpp:433:7: warning: variable 'xd' set but not used [-Wunused-but-set-variable]
M2MFstAligner.cpp:433:24: warning: variable 'yd' set but not used [-Wunused-but-set-variable]
PhonetisaurusOmega.cpp:287:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
PhonetisaurusOmega.cpp:287:46: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
PhonetisaurusOmega.cpp:294:55: warning: 'phi_cost' may be used uninitialized in this function [-Wmaybe-uninitialized]
PhonetisaurusOmega.cpp:294:55: warning: 'phi_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
PhonetisaurusOmega.cpp:339:50: warning: 'phi_cost' may be used uninitialized in this function [-Wmaybe-uninitialized]
PhonetisaurusOmega.cpp:339:50: warning: 'phi_id' may be used uninitialized in this function [-Wmaybe-uninitialized]
phonetisaurus-g2p-omega.cpp:18:22: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
* phonetisaurus-calculateER* should escape arguments before passing them to shell. Or, better, they should use the subprocess module instead of os.system(). 

--
Jakub Wilk

--- End Message ---
Reply to: