Bug#719286: Please upload hiredis 0.11.0-3?

On Sun, Aug 11, 2013 at 3:37 AM, Alessandro Ghedini <ghedo@debian.org> wrote:

owner 719286 ghedo@debian.org
tags 719286 pending
kthxbye

[ also CCing the RFS bug ]

On sab, ago 10, 2013 at 09:32:29 -0700, Tom Lee wrote:
> Hey Alessandro,

Hi,

> Not sure if this is the right email address to contact you on, but I've
> forwarded my upload request for hiredis on to debian-mentors.

My canonical Debian contact would be ghedo@debian.org but this other address is
fine as well (also, I'm not subscribed to debian-mentors). Sorry if you had to
waste your time for the inactive email address thing.

Oh no problem at all. No time wasted. I'll be sure to use this email address in the future.

> https://mentors.debian.net/package/hiredis
>
> No response from them yet, but if you're out there I figure you may want to
> know so there's no duplication of effort here.

I've looked into the package and it mostly looks good. In the other email you
mentioned that this is supposed to fix bug #717611 but there's no mention of it
in the changelog. Usually, when an entry in the changelog fixes a bug filed in
the BTS, you should also mention the bug number so that a) people reading the
changelog can trace the fix back to the bug report and b) when the bug number
is listed in the changelog (with a "special" syntax), the original report is
automatically closed when the package is uploaded (so that you don't have to do
it manually). See [0] for more info.

D'oh, I remember wondering about that when I was editing the change log. Meant to check on that!

I've updated the changelog manually. I've also modified the timestamp to reflect the time at which it was edited, not sure if that's necessary.

If you use the git-dch/gbp-dch script in the git-buildpackage package to
generate the changelog, you can also add a special meta-tag in the git commit
listing the bugs fixed by that commit, and they will automatically show up in
the changelog with the correct syntax when git-dch is run. Have a look at the
"META TAGS" section in the git-dch/gbp-dch(1) man page.

Sure, I'll keep a note of that for next time.

A final suggestion: you should not create the debian/* tags in the git
repository before the package is uploaded, otherwise (as in this case) you may
have to delete the tag if you need to make any modifications suggested by a
sponsor.

This occurred to me after I had created & pushed the tag. :) I'll delete it now & wait for your a-OK before I tag it again.

(also, there's no need to upload to mentors.debian.net a fixed package, git is
fine for me).

Great -- thanks! I only uploaded to mentors.debian.net because I hadn't heard anything back from you. Now that I have your canonical @debian.com address, I'll use that :)

--
Tom Lee / http://tomlee.co / @tglee