Hi, Adam, On Tue, Apr 16, 2013 at 11:03:33AM -0400, Adam Stokes wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > I believe I've fixed all of the above issues and they were committed > upstream today[1][2]. > > dget -x > http://mentors.debian.net/debian/pool/main/s/sosreport/sosreport_2.3+git20130416-1.dsc > This version looks better then the original one, but there are still some minor glitch should be fixed: 1) lintian information, you should run lintian with '-IE --pedantic', lintian will tell you more if there are any problem. There are still some lintian information, but I don't care of them. you may fix them when you polish your package. 2) You use old format copyright files, it is better to switch to DEP5[1] compatible format. lintian shows this information. 3) The section is python, but I think admin should be better, after all, sosreport is a sysadmin tool 4) Please move LICENSE file to usr/share/doc/sosreport, rather than remove it. [1] http://dep.debian.net/deps/dep5/ You should fix 4) before I can upload it to ftp-master, others are just for advice. Thanks and Regards, -- Liang Guo http://bluestone.cublog.cn
Attachment:
signature.asc
Description: Digital signature