[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#706820: RFS: mytop/1.9.1-1 ITA



On Sun, May 05, 2013 at 11:40:31AM +0200, Werner Detter wrote:

Hi,

>  * URL             : http://www.mysqlfanboy.com/mytop/ 

Unreachable from here currently, when have you reached that site the
last time?

>   * Checked and recreated patchs from old upstream against new version
>     - Add 01_fix_pod.patch
>     - Add 02_remove_db_test.patch
>     - Add 03_fix_newlines.patch 
>     - Add 04_fix_unitialized.patch
>     - Add 05_fix_terminal_flicker.patch
>     - Add 06_prevent_ctrl_char_printing.patch
>     - Add 07_fix_screenwidth.patch (Closes: #565759)
>     - Add 08_add_doc_on_missing_cli_options.patch
>     - Add 09_add_mycnf.patch, contains now error handling (Closes: #627300,
>       #694555)
>     - Add 10_q_is_quilt.patch
>     - Add 11_fix_warnings.patch

Uh fun to review ... I find the naming of patch 10 a bit confusing or is this
a pun I don't get currently?
How many of these patches have been proposed for upstream inclusion?

Beside that I wonder if it would make sense to rely more on the dh_ tools
instead of self crafted stuff like

        cd debian/tmp ; find . -type f ! -path "./DEBIAN*" -print0 | xargs -0 md5sum | sed -e 's!\./!!' > DEBIAN/md5sums
        chmod 644 debian/tmp/DEBIAN/md5sums
        dpkg-gencontrol -isp
        chown -R root.root debian/tmp
        chmod -R go=rX debian/tmp
        dpkg --build debian/tmp ..
        dh_perl
        dh_md5sums

It doesn't even make sense to generate the md5sum file first by hand, create
the package itself and then run dh_perl and dh_md5sums. dh_perl even throws
out a visible message that someting is wrong. And yes that is wrong.

The naming of the mytop.example file is also a bit unlucky since that would
also match dh_installexamples, and yes I see that's currently not used
in this package but could be a source of further confusion.

For the maintainerscripts I'll have to reread the relevant policy parts myself
first. If it was my package I wouldn't even install a menu item for such a
tool but that's up to you in the end. Oh and dh_installmenu exists to free
one from the burden of writing the correct maintainer scripts for that task.

Sven
-- 
we live we love we learn and breathe / each breath we take makes me believe
that we can take this road forever / if we take this road together
                                                 [ AZ0 - Endless Roads ]


Reply to: