Bug#667904: RFS: mitlm/0.4-1 [ITP] -- MIT Language Modeling

[Giulio Paci <giuliopaci@gmail.com>]

Il 09/04/2013 12:59, Jakub Wilk ha scritto:
> Lintian emits:
> X: libmitlm0: shlib-calls-exit usr/lib/libmitlm.so.0.0.0
> 
> I believe this is true-positive. exit() is indeed called in some methods that are part of public API:
> 
> NgramLM::Initialize
> NgramModel::LoadComputedFeatures
> 
> They should probably throw an exception instead.

Added a patch to throw exceptions instead of calling exit.

> Also, printing errors/warnings to stderr (here via the Logger class) is not something you normally do in a shared library. At the very least there should be a way to turn
> these messages off, or redirect them somehwere else.

Added patch that adds Logger methods to turn messages off or redirect them.

Bests,
	Giulio.