Bug#696973: RFS: mp3diags/1.0.12.079-1
On Sat, Feb 23, 2013 at 8:15 PM, Sebastian Ramacher
<sramacher@debian.org> wrote:
> Control: owner -1 !
>
> Hi Josué,
>
> I had a look at your mp3diags package and found the following issue. Once the
> issues are fixed I'm happy to upload the package for you.
>
> On 2012-12-29 21:44:47, Josué Ortega wrote:
>> dget -x http://mentors.debian.net/debian/pool/main/m/mp3diags/mp3diags_1.0.12.079-1.dsc
>
> * Please prepare an upload to experimental so that we can keep unstable clean
> until the release of wheezy.
>
> * -g is not passed to the compiler and thus DEB_BUILD_OPTIONS=nostrip is not
> supported. Please check Debian Policy §4.9.1 and §10.1.
>
> * The package is built without hardening flags. In particular lintian emits:
>
> W: mp3diags: hardening-no-relro usr/bin/mp3diags
> W: mp3diags: hardening-no-fortify-functions usr/bin/mp3diags
>
> Please build the package with hardening flags enabled and check the build log
> with blhc.
>
> The last two issues can be solved by using dpkg-buildflags directly or by
> including /usr/share/dpkg/buildflags.mk in debian/rules. dh_auto_* also set
> them in compat level 9.
>
> * The package fails to build twice in a row. Please have a look at the
> attached file for the log of the second build. The files dpkg-source is
> complaining about come from running cmake by dh_auto_configure. However,
> elsewhere qmake is used to build mp3diags. Please decide on one of these
> two build systems.
>
> If you choose qmake, note that debhelper supports qmake since 7.4.12. So
> removing the overrides for dh_auto_clean, dh_auto_build and passing -Sqmake
> to dh should be enough.
>
> * lintian also emits:
>
> W: mp3diags source: out-of-date-standards-version 3.9.3 (current is 3.9.4)
> I: mp3diags: spelling-error-in-binary usr/bin/mp3diags teH the
>
> Please fix these issues and ping me when you're done.
>
> One other thing: Vcs-* lists a collab-maint repo which has not been updated
> since the last upload by Alessio. It'd be great if you could push your work
> there. If you just don't have access to this repository, please say so.
>
> Cheers
> --
> Sebastian Ramacher
Hi Sebastian,
First of all thanks for all your advices, they were very useful :).
I just uploaded the package to mentors with the fix for the previous issues [0].
About the Vcs-*, I removed the fielf from debian/control because I
decided not to use that system.
I'll be wating for your feedback, thanks in advance.
Cheers
[0]: http://mentors.debian.net/package/mp3diags
--
Josue Ortega
http://josueortega.org
PGP key 4096R/AB4AFD3F 2012-08-20
Fingerprint = 7733 B328 D279 5F5B E232 5ADD 0150 9D5C AB4A FD3F
Reply to: