Re: Changelog etiquette for upstream patches
On Fri, 1 Mar 2013 11:03:50 -0500
Ryan Kavanagh <rak@debian.org> wrote:
> Hi Tony,
>
> On Fri, Mar 01, 2013 at 03:54:24PM +0000, Tony Houghton wrote:
> > As both the upstream and Debian maintainer for roxterm I'm unsure what
> > to do about documenting a patch that was submitted by someone else to
> > the upstream tracker.
>
> I would document this information using a DEP-3 header[0], in
> particular, the Author and Origin fields. If it's linked to an upstream
> bug report, link to that bug report as well.
>
> Author: John Doe <jdoe@example.com>
> Origin: link to patch applied in upstream VCS
> Bug: http://upstream.bugtrackerurl/1275270
>
> > I've applied the patch upstream but don't know the best way to credit
> > the author in debian/changelog. Include his name?
>
> I would either write
>
> * Apply upstream patch fixing frobnicator, 02_fix_frob.diff
> (Closes: #245274)
>
> letting people look at the patch header for credits, or
>
> * Apply upstream patch by John Doe fixing frobnicator, 02_fix_frob.diff
> (Closes: #245274)
The thing is there isn't a separate patch in the debian packaging or
elsewhere in the pending release tarball because I've applied the patch
to the code upstream. The bug is upstream too, not in Debian. So
including the URL for the upstream bug looks nearest to your suggestion.
Luckily sourceforge bug URLs are a more reasonable size since the last
upgrade, and/or I can use their URL shortening service.
Reply to: