Bug#679344: RFS: bzr-email/0.0.1~bzr58-1 [ITA]

[Satoru KURASHIKI <lurdan@gmail.com>]

hi,

Thank you for reviewing this package!

On Sun, Jul 22, 2012 at 3:48 AM, Bart Martens <bartm@debian.org> wrote:
> I found this in debian/copyright :
>
>     Source: branch from http://launchpad.net/bzr-email and hand-packed
>      by "tar cf - | gzip -9".
>
> That's not really "detailed information".  I figured out that it means this :

Yes, I had (too) shorten them....

> But then I saw that launchpad supports downloading a tarball for a given
> revision :
> http://bazaar.launchpad.net/~bzr/bzr-email/trunk/revision/58
>
> So, I suggest to simply use that in debian/copyright.

I missed this launchpad feature, and sure, I want use it if available.

But anyway that tarball include deep directory hierarchy (prepended
"~bzr/bzr-email/trunk"), and I don't know how to deal with this.
So, I try to add get-orig-source target to repack that tarball.

> The years of the copyright notices in debian/copyright need an update.  See for
> example the years in emailer.py.

I update this to noted years.

> I see that some parts of debian/copyright were removed.  Intentional ?  It's
> not mentioned in debian/changelog.

Yes, intentional. I deleted one paragraph which is duplicate and old.
I write changelog about it.

> For completeness you could also mention in debian/changelog the changes to the
> Vcs-fields in debian/control.

I also add this.

Its changelog is to be (adding also DMUA):

bzr-email (0.0.1~bzr58-1) unstable; urgency=low

  * New upstream snapshot.
    - add get-orig-source target.
  * New Maintainer. (Closes: #668266)
    - DM-Upload-Allowed.
  * debian/control:
    - change VCS to git.
    - suggests mailx. (Closes: #626490)
  * debian/copyright:
    - omit duplicate old description for getting GPL copy.
    - document about repackaged upstream source.

regards,
-- 
KURASHIKI Satoru