[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#679344: RFS: bzr-email/0.0.1~bzr58-1 [ITA]



Hi KURASHIKI Satoru,

As I commented earlier for your package at mentors uploaded there on 2012-06-28
00:14, detailed information on how the repackaged source was obtained, and on
how this can be reproduced should be provided in debian/copyright.
http://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-origtargz

I found this in debian/copyright :

    Source: branch from http://launchpad.net/bzr-email and hand-packed
     by "tar cf - | gzip -9".

That's not really "detailed information".  I figured out that it means this :

    bzr branch lp:bzr-email
    rm -r bzr-email/.bzr
    rm bzr-email/.bzrignore
    mv bzr-email bzr-email_0.0.1~bzr58
    tar cf bzr-email_0.0.1~bzr58.orig.tar bzr-email_0.0.1~bzr58
    gzip -9 bzr-email_0.0.1~bzr58.orig.tar

But then I saw that launchpad supports downloading a tarball for a given
revision :
http://bazaar.launchpad.net/~bzr/bzr-email/trunk/revision/58

So, I suggest to simply use that in debian/copyright.

The years of the copyright notices in debian/copyright need an update.  See for
example the years in emailer.py.

I see that some parts of debian/copyright were removed.  Intentional ?  It's
not mentioned in debian/changelog.

For completeness you could also mention in debian/changelog the changes to the
Vcs-fields in debian/control.

Regards,

Bart Martens


Reply to: