Bug#673600: RFS: nyancat/1.0+git20120519.5fe3de9-1
On Sat, Jun 02, 2012 at 07:03:33PM +0000, Jakub Wilk wrote:
> * Jonathan McCrohan <jmccrohan@gmail.com>, 2012-06-02, 19:27:
> >>I would add -x/--line-regexp to the fgrep call.
> >>
> >>Wouldn't it be nice if the postinst also take care of the case when
> >>the user enabled the service?
> >
> >Couldn't both of these issues be addressed by removing '#<off># ' from
> >the grep?
>
> I think we do need -x (or an equivalent of it). If the user appended
> some options to nyancat-server command-line, we must not remove such
> entry.
agreed. I'd keep it simple and use two fgrep -x invocations; one with and
another without '#<off># '
> BTW, shouldn't you use --pattern (instead of, or maybe in addition to,
> --multi)?
--patern is not implemented for --remove. I guess I should add support for it.
--
Every great idea is worthless without someone to do the work. --Neil Williams
Reply to: