Hi Gregor, thanks for reviewing my package! I've fixed all points you mentioned. There still the problem that the package name (sun) might be too generic to be included in the archive. What do you think about this concern? I've collected some alternatives: solar suncal atsun sunrun suncycles - makes no sense to me Am Sonntag, den 23.12.2012, 23:17 +0100 schrieb gregor herrmann: > - The package doesn't build on a machine / in a chroot without > internet access because the tests fail: fixed. I moved the binary from the check_ prefix to the noinst_ prefix. So it gets compiled for testing purposes but not installed by automake. > - You can remove the override_dh_auto_configure in debian/rules if > you use debhelper (>= 9) in debian/control and 9 in debian/compat. fixed. > - Current Standards-Version is 3.9.4. fixed. > - You don't need the version restrictions for pkg-config libjson0-dev > libcurl4-openssl-dev in debian/control, for all 3 packages there > are no older versions in the archive. fixed. > - Please run lintian with all bells and whistles turned on against > the .changes file. It reports for me: > debian-watch-contains-dh_make-template and > 3x hyphen-used-as-minus-sign for the manpage fixed. I've run lintian with --pedantic -E. No more warnings are showing up. Just debian-mentor's lintian claims: newer-standards-version 3.9.4 (current is 3.9.3) > - Installing the empty NEWS file doesn't look so helpful :) > (And I'd rename docs to sun.docs for consistency with > sun.manpages.) fixed. Automake requires the NEWS file. So, I removed it from debian/sun.docs. I uploaded a the updated package to debian-mentors [1]. Regards, Steffen [1] http://mentors.debian.net/package/sun -- Steffen Vogel Robensstraße 69 52070 Aachen Mail: post@steffenvogel.de Mobil: +49 176 34911387 Web: http://www.steffenvogel.de Jabber: stv0g@jabber.ccc.de ICQ: 236033
Attachment:
signature.asc
Description: This is a digitally signed message part