[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#696600: RFS: sun/0.2-1 [ITP] schedule cron or at-jobs at sunrise/set



Control: tag -1 + moreinfo

On Sun, 23 Dec 2012 20:01:11 +0100, Steffen Vogel wrote:

> I am looking for a sponsor for my new package "sun"
> 
>  Package name    : sun
>  Version         : 0.2-1
>  Upstream Author : Steffen Vogel <post@steffenvogel.de>
>  URL             : https://github.com/stv0g/sun
>  License         : GPL
>  Section         : utils
> 
> Alternatively, one can download the package with dget using this
> command:
> dget -x http://mentors.debian.net/debian/pool/main/s/sun/sun_0.2-1.dsc

Really a nice tool.

I took a quick and probably not complete look at the package, some
notes:

- The package doesn't build on a machine / in a chroot without
  internet access because the tests fail:
  
make  check-TESTS
make[3]: Entering directory `/tmp/buildd/sun-0.2/src'
request failed: Couldn't connect to server
FAIL: geonames
=====================================
1 of 1 test failed
Please report to post@steffenvogel.de
=====================================

- You can remove the override_dh_auto_configure in debian/rules if
  you use debhelper (>= 9) in debian/control and 9 in debian/compat.

- Current Standards-Version is 3.9.4.

- You don't need the version restrictions for pkg-config libjson0-dev
  libcurl4-openssl-dev in debian/control, for all 3 packages there
  are no older versions in the archive.

- Please run lintian with all bells and whistles turned on against
  the .changes file. It reports for me:
  debian-watch-contains-dh_make-template and 
  3x hyphen-used-as-minus-sign for the manpage

- Installing the empty NEWS file doesn't look so helpful :)
  (And I'd rename docs to sun.docs for consistency with
  sun.manpages.)

Thanks for writing this nice tool!


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Peter Ratzenbeck: Foggey Dew

Attachment: signature.asc
Description: Digital signature


Reply to: