Bug#691893: RFS: roundup/1.4.20-2 [RC]
* Kai Storbeck <kai@xs4all.nl>, 2012-10-30, 23:18:
http://mentors.debian.net/debian/pool/main/r/roundup/roundup_1.4.20-2.dsc
I don't intend to sponsor this, but here's my review:
+ * Remove conffiles only on purge.
I don't see this change in the debdiff...
+ * do not remove roundup user on purge, due to possible dataloss
A pointer to the discussion why removing users on purge is a bad idea
(e.g. to bug #621833) would be helpful.
But as above, I don't see any changes to the maintainer scripts.
+ * cleanup postrm and postinstall to use #DEBHELPER# tags
I don't see this change in the debdiff...
-Build-Depends-Indep: python (>= 2.6.6-3~), debhelper (>= 7.4)
+Build-Depends-Indep: debhelper (>= 7.4),
+ python (>= 2.6.6-3~),
+ python-setuptools,
+ python-sphinx (>= 1.0.7+dfsg)
What is the build-dependency on python-setuptools for? This addition is
not documented in the changelog.
At least debhelper, python, and python-sphinx are needed in the clean
target, to they should be in Build-Depends, not Build-Depends-Indep.
Please try avoiding reordering fields in debian/control; it makes
reviewing debdiff harder than necessary.
-Description: an issue-tracking system
+Description: Issue-tracking system in python
There's no reason for "I" to be uppercase.
The addition of "in python" is not documented in the changelog? Why is
it important that it's in Python (not "python"), BTW?
+Document: roundup
+Title: Roundup documentation
+Author: Roundup developers
+Abstract: This manual describes Roundup, the issue tracker.
+Section: Project Management
+
+Format: HTML
+Index: /usr/share/doc/roundup/html/index.html
+Files: /usr/share/doc/roundup/html/*
This change is not is not documented in the changelog.
+ status)
+ status_of_proc $EXECUTABLE $BINFILE && exit 0 || exit $?
+ ;;
Ditto.
+/usr/share/javascript/jquery/jquery.js /usr/share/roundup/_static/jquery.js
I'm confused. Shouldn't that be /usr/share/roundup/_static/doc/jquery.js
(note missing /doc/ compontent)? But in this case, dh_sphinxdoc already
takes care of symlinking the file...
PACKAGE=roundup
-UPSTREAM_VERSION=1.4.20
DEB_SRCDIR=$(CURDIR)
ROOT=$(DEB_SRCDIR)/debian/$(PACKAGE)
DEB_BUILDDIR=debian/$(PACKAGE)
-DOC=$(DEB_SRCDIR)/debian/$(PACKAGE)/usr/share/doc/$(PACKAGE)
This change is not is not documented in the changelog.
+override_dh_auto_build:
+ python setup.py build
If you called "dh_auto_build" here instead of "python setup.py build" it
would be more obvious that the change is correct.
--
Jakub Wilk
Reply to: