[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#663916: New phonetisaurus package available



Errata corrige.

Il 22/10/2012 23:55, Giulio Paci ha scritto:
> Il 22/10/2012 17:48, Jakub Wilk ha scritto:
>> * Giulio Paci <giuliopaci@gmail.com>, 2012-10-21, 15:04:
>>> Is it mandatory to identify "possibly useless" flags and to hide them?
>>
>> I understand that removing/hiding unneeded option might be infeasible, but I would expect that these no-ops are documented as such in the manual page (or alternative: that
>> they are not documented in the manpage at at all).
> 
> Removed those flags from the manpages.
> 
>> 1) Upstream "make clean" is not idempotent: it fails it there's nothing to clean. Replacing "rm" with "rm -f" should fix this issue.
> 
> Fixed by using $(RM).

>> 2) cdbs doesn't ignore errors from "make clean". This was reported in #441020 over 5 years ago. (Sigh...) 

I just read the bug report. Actually cdbs ignores errors in "make clean".
So the problem here seems to be that building should fail on "make clean", but it was working anyway. Right?

>> There's a warning about debian/copyright_hints not being up-to-date.
> 
> Fixed.

I re-created the problem by adding the new patch. Now it is fixed (again).

>> There's also a few dozens of compiler warnings. Is upstream aware of them?
> 
> I just sent an email about them, along with a patch removing most of them. I left untouched those warnings that I was not sure how to solve properly. I am waiting upstream
> to solve them.

The patch header was broken, I fixed it.

Bests,
	Giulio.


Reply to: