[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689715: Review of eyefiserver


On Tuesday 16 October 2012 07:01:11 Vincent Fourmond wrote:
> > On Wednesday 10 October 2012 19:59:11 Vincent Fourmond wrote:
> >>>>   * I don't see the point of including session dumps - especially 4MB of them !
> >>> Absolutely. Done.
> >>> I did not change the orig tarball however. Right?
> >>   Hmmm... I'm unsure about that, since the copyright status of the
> >> dumps is somehow unclear (and their license too). I'm afraid the
> >> FTPmasters would not appreciate that much. I leave it up to you to
> >> dedice however...
> (...)
>   The thing is: what is the copyright status of such a thing ? Is it
> free ? To me, it seems that it's a bit like a screenshot of a game --
> it can only be considered free if the game is free, which, in this
> case, isn't true. I understand that you, as a developer, found this
> dump extremely useful. But will the users care ?
> (...)

Several things occured:

First, upstream, the http dump file was reduced from a 4MB to a 8kB,
removing the uninteresting binary part of the image. This was release
as release candidate 2. This is the only upstream change.

Then, since that dump have an unclear license, I also removed it from
the orig file using a +dfsg version.

>>>   (...) Please mark the changes in debian/changelog.
>> This is weird. I tried many things before, but did not show them in the
>> changelog, since this is before first version. See:
>> http://anonscm.debian.org/gitweb/?p=collab-maint/eyefiserver.git;a=commitdiff;h=0f8a8577bdc3272327eee05c04ae9d35a4fdcc61
>> Would that be better to keep that stuff too?
>  What I'm asking is just personal taste, but as a sponsor, I like to
> see what happened since I last looked by just a glance at the
> changelog - for the first upload or any subsequent one. Hence my
> request ;-). So you don't need to dump all your git log from the
> initial import to the first changelog...

I'm now showing the changes for unreleased versions.

Beside removing the dump, that version also fix the watch file:
Github provides taged snapshots without the extension and uscan
doesn't like that. See --rename restrictions in uscan(1).

You can download the package with dget using this command:

 dget -x http://mentors.debian.net/debian/pool/main/e/eyefiserver/eyefiserver_2.3~rc2+dfsg-1.dsc

Thank you

Attachment: signature.asc
Description: This is a digitally signed message part.

Reply to: