[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#673087: RFS: the-powder-toy/78.1-1 [ITP] -- Physics sandbox game


Thanks for your review and your interest. :)

Upstream just switched their codebase from C to C++, so I need to fix all of my packaging and update it to work well. However, they have not figured out a way to "release" version numbers through tags/commits - they don't keep the version number in the code yet. As soon as they do that (preferably through tags), I'll update the package and put it pack up here for sponsorship.

Also, thank you for reviewing my package and providing me the warnings. I'm not sure how I didn't see those Lintian errors before.

One last thing:

How can I commit the package to the pkg-games VCS?


On Fri, Oct 12, 2012 at 4:22 AM, Bas Wijnen <wijnen@debian.org> wrote:

On 12-10-12 10:00, Andreas Tille wrote:
> not that I would specifically interested in this very package (just
> stumbled upon it because of the "physics" keyword) I think you could
> enhance your chances to find a sponsor if you would more closely join
> the pkg-games team (by for instance following the group packaging policy
> and commit the packaging to VCS).

I looked through the package, and it looks fine. However, I have a
problem with upstream's policy to make the program phone home.

You correctly removed the "install" option. However, on every run of the
program it still checks if there is a newer version available. On
Debian, no program needs to do this: the packager sees the new version
and should package it, the user will find it the next time apt is
updating the system.

If this feature would be required by the license, it would not be free
software. It isn't, so the license is fine. It is still a very good idea
to remove all network actions, except those that are good for the user.
I haven't seen what the user gains from this network access, but there
might be features that improve the user's experience by using the
network (like sharing simulations with each other, or something like
that). "You can only save if you register first" most certainly is not
one of them, and this limitation should be removed.

>> Please review this package version instead of the one mentioned earlier.
>> This one should be lintian and pbuilder clean

On my system (running unstable), I did get some lintian warnings:

W: the-powder-toy-dbg: wrong-section-according-to-package-name
the-powder-toy-dbg => debug
W: the-powder-toy-dbg: debug-package-should-be-priority-extra
W: the-powder-toy: hardening-no-relro usr/lib/games/the-powder-toy/powder
W: the-powder-toy: hardening-no-fortify-functions


Reply to: