[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#689715: Review of eyefiserver-2.3~rc1-1

On Sun, Oct 7, 2012 at 2:58 PM, Jean-Michel Vourgère <jmv_deb@nirgal.com> wrote:
> Hello and thank you very much for your review!
> On Sunday 07 October 2012 09:09:28 Vincent Fourmond wrote:
>>   * I'd prefer the package to target experimental as of now; upload to
>> unstable will follow the release of wheezy
> It makes sense. Done.
>>   * I don't see the point of including session dumps - especially 4MB of them !
> Absolutely. Done.
> I did not change the orig tarball however. Right?

  Hmmm... I'm unsure about that, since the copyright status of the
dumps is somehow unclear (and their license too). I'm afraid the
FTPmasters would not appreciate that much. I leave it up to you to
decice however...

>>   I'd be glad to upload once these problems are fixed. Don't increase
>> the debian version number, but please mark the changes in
>> debian/changelog.
> This is weird. I tried many things before, but did not show them in the
> changelog, since this is before first version. See:
> http://anonscm.debian.org/gitweb/?p=collab-maint/eyefiserver.git;a=commitdiff;h=0f8a8577bdc3272327eee05c04ae9d35a4fdcc61
> Would that be better to keep that stuff too?

  What I'm asking is just personal taste, but as a sponsor, I like to
see what happened since I last looked by just a glance at the
changelog - for the first upload or any subsequent one. Hence my
request ;-). So you don't need to dump all your git log from the
initial import to the first changelog...

> I uploaded a new version to mentors, with just that last change in the changelog.

  Great. I'm waiting for your answer on my first comment, and I'll upload then.



Reply to: