Bug#669565: RFS: gammaray/1.1.0-1 [ITP] -- Tool for examining the internals of Qt application
Hi Felix,
thanks for looking at the gammaray package.
On 9.8.2012 21:10, Felix Geyer wrote:
debian/rules:
.PHONY: override_dh_strip
Seems a bit inconsistent to only add dh_strip.
Indeed, added also the rest of the targets.
dh $@
Please enable parallel building.
Added --parallel to dh arguments.
override_dh_auto_test:
# Do not perform test suite as it requires X11 running
You can run the tests by build-depending on xvfb and calling
xvfb-run dh_auto_test
Works fine, thanks. Besides xvfb, xauth is required in Build-Depends too.
I also added gdb so that more test cases can be run.
debian/patches/debian-multiarch.patch:
This one is not really needed since you can't co-install gammaray for
multiple architectures anyway.
Okay, removed.
debian/patches/gammaray-probe-versioned-soname.patch:
Why do you set a SONAME for gammaray_probe?
When gammaray changes the ABI custom plugins will break anyway
since you can't install different versions of gammaray.
When SONAME is not set, lintian produces these warnings and error:
W: gammaray: dev-pkg-without-shlib-symlink usr/lib/gammaray_probe.so usr/lib/gammaray_probe.so
W: gammaray: shlib-without-versioned-soname usr/lib/gammaray_probe.so gammaray_probe.so
E: gammaray: postinst-must-call-ldconfig usr/lib/gammaray_probe.so
So the right solution is to override the warnings and add ldconfig call into
postinst script by hand?
debian/patches/harfbuzz-search-path.patch:
What does this patch do?
libqt4-private-dev doesn't contain the harfbuzz headers and that won't
change at least until wheezy is released.
I've already created a request for harfbuzz headers inclusion [1]. Right now,
that patch has no visible effect, but once the headers are available, it will
be enough to simply recompile gammaray to enable the additional features that
now can't be built.
Regards,
Jakub
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680869
Reply to: