Bug#669565: RFS: gammaray/1.1.0-1 [ITP] -- Tool for examining the internals of Qt application

[Felix Geyer <fgeyer@debian.org>]

Hi,

Here is a quick review of the package:

debian/rules:

> .PHONY: override_dh_strip

Seems a bit inconsistent to only add dh_strip.

>     dh $@

Please enable parallel building.

> override_dh_auto_test:
>     # Do not perform test suite as it requires X11 running

You can run the tests by build-depending on xvfb and calling
xvfb-run dh_auto_test


debian/patches/debian-multiarch.patch:

This one is not really needed since you can't co-install gammaray for
multiple architectures anyway.


debian/patches/gammaray-probe-versioned-soname.patch:

Why do you set a SONAME for gammaray_probe?
When gammaray changes the ABI custom plugins will break anyway
since you can't install different versions of gammaray.


debian/patches/harfbuzz-search-path.patch:

What does this patch do?
libqt4-private-dev doesn't contain the harfbuzz headers and that won't
change at least until wheezy is released.

Felix