[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#677013: Debian time package sponsor?



Ferenc Wagner wrote:
> Bob Proulx writes:
> > Yes.  But note that those had been made before too.  I only updated
> > the autotools files (again) because the current ones were quite aged
> > and dearly in need of being updated.  Those were not "patched" in the
> > sense of editing the file with changes but updated whole by using the
> > current autotools to create new versions of those files from the
> > included source files.  (The source being the configure.ac and
> > Makefile.am files.)
> 
> Did you consider using dh-autoreconf or dh --with autotools_dev?

As far as I know from reading the documentation using dh-autoreconf
and dh --with autotools_dev update only the config.sub and
config.guess files if they exist.  The 'time' package does not use
either of the config.sub or config.guess files and neither exist in
the package.  Therefore AFAIK calling dh_autotools_dev would be a
noop.

I was basically following Option 1 from the autotools-dev README file.
I would have used dh_autoreconf but I didn't know how to force it to
be run in the dh system.  But digging more into it and searching the
web I now find that there is a 'dh $@ --with autoreconf' option.
Maybe that was the option you were thinking of but your fingers typed
in the other one by mistake?  Probably.  In any case if that works
then that is most desirable.  I will explore that technique.  (Time
passes...)  That seems to work.  Adding the build dependencies needed
for it and converting to using that recipe.

> >> Addenda, taken from lintian output after build:
> >> 
> >> I: time source: debian-watch-file-is-missing
> >>  is it possible to add it? does it make sense for a GNU project?
> >
> > Up to date lintian does not give me that message.
> 
> You need to add the --info option to get Info level messages.

Ah!  Thank you for that hint.

> >> W: time: hardening-no-fortify-functions usr/bin/time
> >>  did you consider enable the hardening flags?
> >
> > That is a brand new lintian warning and did not exist when I built the
> > package.  So the answer is no that I did not consider it.  It wasn't
> > an item to be considered at that time.  I am skeptical that time would
> > gain value by using them.  But I am not opposed to adding them.
> >
> > However I am using the debhelper build system.  Shouldn't it be doing
> > this automatically there?  Isn't that the purpose of using such a
> > build system so that standardized behaviors are implemented uniformly
> > across everything all at once?
> >
> > How does one enable hardening flags when using the dh build system?
> 
> Debhelper compat level 9 makes this automatic with a recent dpkg-dev.
> (If I'm not mistaken.)

If that is true then nothing more needs to be done.

> >> P: time: no-homepage-field
> >>  can you please add it?
> >
> > Up to date lintian does not give me that message.
> 
> This is a Pedantic message, use the --pedantic option to enable these.

Ah, again!  That is a good hint.

Thanks!
Bob



Reply to: