Bug#677013: Fwd: Debian time package sponsor?
as requested
---------- Forwarded message ----------
From: Sandro Tosi <morph@debian.org>
Date: Sat, Jun 9, 2012 at 5:09 PM
Subject: Re: Debian time package sponsor?
To: Bob Proulx <bob@proulx.com>
Hello Bob,
here's a brief review of the package.
debian/changelog
- don't rewrite history, so please restore the old changelog entries,
even if they have a weird "Closes=xxx" in the first entry line
debian/control
- why didn't you bump debhelper to 9, which is the latest version?
just to undestand if there was some reason
- I personally would have left 'GNU time' in the short description line
debian/copyright
- you misses to state the previous maintainer(s) copyright. While this
is non necessary for teh upload, is kinda rude ;) please add at least
the entry for Tollef (easily gettable from the start to the end of his
maintainership of the package).
debian/time.1
- did you consider pushing the manpage upstream?
debian/source/format
- is there some reason not to move to the "3.0 (quilt)" format?
I also see that there are several changes performed directly in the
upstream code, such as autotools/configure/make and friends, .info
file and so on. It would be clearer if they were separate patches
living in the debian/patches directory, so to clearly identify why a
change has been made, and possible traking its upstream merge.
They are quite easy to fix, so the faster you reply and prepare a new
pkg, the quicker I'll upload :)
Addenda, taken from lintian output after build:
I: time source: debian-watch-file-is-missing
is it possible to add it? does it make sense for a GNU project?
W: time: hardening-no-fortify-functions usr/bin/time
did you consider enable the hardening flags?
P: time: no-homepage-field
can you please add it?
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:99
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:135
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:136
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:245
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:247
I: time: hyphen-used-as-minus-sign usr/share/man/man1/time.1.gz:254
it would be nice if the manpage would be fixed with them too
Cheers,
--
Sandro Tosi (aka morph, morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
Reply to: